Skip to content

Commit

Permalink
[#144] fix for empty additional options
Browse files Browse the repository at this point in the history
Add additional options only if not empty.

fixes #144
  • Loading branch information
ghentschke committed Jul 3, 2023
1 parent ac75bcb commit d21c9c0
Showing 1 changed file with 7 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ public String queryDriver() {

@Override
public List<String> additionalOptions() {
return Arrays.asList(stringValue(metadata.additionalOptions()).split("\\R")); //$NON-NLS-1$
var options = stringValue(metadata.additionalOptions());
if (options.isBlank())
return new ArrayList<>();
return Arrays.asList(options.split("\\R")); //$NON-NLS-1$
}

private String stringValue(PreferenceMetadata<?> meta) {
Expand Down Expand Up @@ -110,7 +113,9 @@ public List<String> toList() {
}
list.add(NLS.bind("--query-driver={0}", queryDriver())); //$NON-NLS-1$

list.addAll(additionalOptions());
var additionalOptions = additionalOptions();
if (!additionalOptions.isEmpty())
list.addAll(additionalOptions);
return list;
}

Expand Down

0 comments on commit d21c9c0

Please sign in to comment.