Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move and rename DefaultCLanguageServerProvider #105

Closed
ghentschke opened this issue Jun 2, 2023 · 0 comments · Fixed by #107
Closed

Move and rename DefaultCLanguageServerProvider #105

ghentschke opened this issue Jun 2, 2023 · 0 comments · Fixed by #107
Assignees
@ghentschke
Milestone
1.0.0

Comments

@ghentschke
Copy link
Contributor

As already mentioned here, the DefaultCLanguageServerProvider should be moved to the org.eclipse.cdt.lsp.clangd bundle, because it is the base implementation for the clangd language server. It should be renamed into BaseClangdLanguageServerProvider and abstract, because vendors should be able to extend this class according to their purposes.
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jun 2, 2023
@ghentschke
[eclipse-cdt#105] Move and rename DefaultCLanguageServerProvider
48bd774 
fixes eclipse-cdt#105
@ghentschke ghentschke mentioned this issue Jun 2, 2023
Merged
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Jun 2, 2023
@ghentschke
[eclipse-cdt#105] Move and rename DefaultCLanguageServerProvider
b83a592 
fixes eclipse-cdt#105
@ghentschke ghentschke self-assigned this Jun 2, 2023
ruspl-afed pushed a commit that referenced this issue Jun 3, 2023
@ghentschke
[#105] Move and rename DefaultCLanguageServerProvider (#107)
7034dba 
fixes #105
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghentschke ghentschke

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[#105] Move and rename DefaultCLanguageServerProvider ghentschke/eclipse-cdt-lsp
2 participants
@jonahgraham @ghentschke