Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some Clangd options in preference/project properties not changeable #120

Closed
ghentschke opened this issue Jun 13, 2023 · 5 comments
Closed

Some Clangd options in preference/project properties not changeable #120

ghentschke opened this issue Jun 13, 2023 · 5 comments
Assignees
@ruspl-afed
Milestone
1.0.0

Comments

@ghentschke
Copy link
Contributor

After change #117 the Pretty-print JSON output setting under Editor (LSP) preference settings are not saved persistent. The changes are missing after reopen the settings or restart of the workbench.

Steps to reproduce:

  1. Enable Pretty-print JSON output under prefs or project properties: C/C++ > Editor (LSP)
  2. Press Apply or Apply and Close
  3. Reopen settings or restart IDE
  4. Pretty-print JSON output is not enabled
@ghentschke
Copy link
Contributor Author

It seems that the Prefer C/C++ Editor (LSP) setting won't be adopted on project level as well.

@ghentschke ghentschke changed the title Clangd preference/project property 'Pretty-print JSON output' not persitent settable Some Clangd options in preference/project properties not changeable Jun 13, 2023
@ruspl-afed ruspl-afed self-assigned this Jun 13, 2023
@ghentschke
Copy link
Contributor Author

The global Prefer C/C++ Editor (LSP) setting in the workspace prefs seem to overwrite the project level setting for Prefer C/C++ Editor (LSP)

@ruspl-afed
Copy link
Member

Seems to be my fault, I'll double check this.

@ghentschke
Copy link
Contributor Author

I think about the usage of the global Prefer C/C++ Editor (LSP) switch. The behavior should be, that the Editor (LSP) settings of a new C/C++ project will be initialized by the global settings.

ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Jun 13, 2023
@ruspl-afed
[eclipse-cdt#120] Clangd options in preference/project properties not…
9a3285e 
… changeable

Set preference store for Properties page when context element is alreayd
known
ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Jun 13, 2023
@ruspl-afed
[eclipse-cdt#120] Clangd options in preference/project properties not…
a3df71a 
… changeable

Set preference store for Properties page when context element is alreayd
known
Correct metadata for query driver preference
ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Jun 14, 2023
@ruspl-afed
[eclipse-cdt#120] Clangd options in preference/project properties not…
cda3f3f 
… changeable

Rework both Properties and Preference page, to reuse approach from other
places like PDE
ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Jun 14, 2023
@ruspl-afed
[eclipse-cdt#120] Clangd options in preference/project properties not…
97a3111 
… changeable

Rework both Properties and Preference page, to reuse approach from other
places like PDE
ruspl-afed added a commit that referenced this issue Jun 14, 2023
@ruspl-afed
[#120] Clangd options in preference/project properties not changeable (…
566c0b7 
…#122)

Rework both Properties and Preference page, to reuse approach from other
places like PDE
ruspl-afed added a commit to ruspl-afed/eclipse-cdt-lsp that referenced this issue Jun 14, 2023
@ruspl-afed
[eclipse-cdt#120] Clangd options in preference/project properties not…
f7d0b9b 
… changeable

Provide explicit default scope
ruspl-afed added a commit that referenced this issue Jun 14, 2023
@ruspl-afed
[#120] Clangd options in preference/project properties not changeable (…
22b3a89 
…#126)

Provide explicit default scope
@ruspl-afed
Copy link
Member

I think we are done here with #122 and #126

@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruspl-afed ruspl-afed

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@jonahgraham @ruspl-afed @ghentschke