Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use combo box for clangd Completion option #168

Closed
ghentschke opened this issue Aug 8, 2023 · 0 comments · Fixed by #169
Closed

Use combo box for clangd Completion option #168

ghentschke opened this issue Aug 8, 2023 · 0 comments · Fixed by #169
Milestone
1.0.0

Comments

@ghentschke
Copy link
Contributor

Clangd fails to start when the completion option is misspelled. A combo box instead of a test field would prevent this failure and shows the user the possible settings as well:
image
Another advantage would the possible internationalization of the selected items strings.
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Aug 8, 2023
@ghentschke
[eclipse-cdt#168] Use combo box for clangd Completion option
46f073e 
fixes eclipse-cdt#168
@ghentschke ghentschke mentioned this issue Aug 8, 2023
Merged
ghentschke added a commit to ghentschke/eclipse-cdt-lsp that referenced this issue Aug 8, 2023
@ghentschke
[eclipse-cdt#168] Use combo box for clangd Completion option
5fb5511 
fixes eclipse-cdt#168
ghentschke added a commit that referenced this issue Aug 8, 2023
@ghentschke
[#168] Use combo box for clangd Completion option
5fb185d 
fixes #168
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[#168] Use combo box for clangd Completion option ghentschke/eclipse-cdt-lsp
2 participants
@jonahgraham @ghentschke