An internal error occurred during: "DSF Source Lookup" #320
Comments
|
Hi, when I take a look at the log file I don't think that this is an cdt-lsp issue. IMO its an esspressif project/IDE issue. |
|
I think there is a null check missing in Will a change like this resolve the issue, i.e. getting the editor id from the editor reference, rather than fully restoring the editor? diff --git a/bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/util/LspUtils.java b/bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/util/LspUtils.java
index b89ca53..6915672 100644
--- a/bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/util/LspUtils.java
+++ b/bundles/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/util/LspUtils.java
@@ -94,7 +94,7 @@
continue;
}
if (editorInput.equals(editorInputFromEditor)) {
- return LspPlugin.LSP_C_EDITOR_ID.equals(editor.getEditor(true).getEditorSite().getId());
+ return LspPlugin.LSP_C_EDITOR_ID.equals(editor.getId());
}
}
// the file has not been opened yet: |
|
@BenthamSoftwareServices can you try to apply the patch and let us know the results. We have ~2 weeks until we release so now is an excellent time to resolve this. |
getEditor can return null. may be a fix for eclipse-cdt#320
|
Thanks @jonahgraham for finding this possible NPE. I created a PR to fix it. This code line will be called when a an external C/C++ file (e.g. a standard library header) is already opened in an editor. |
getEditor can return null. may be a fix for eclipse-cdt#320
Yes I would like to try the patch, can you explain to me where it is and how to apply it please. |
|
@BenthamSoftwareServices which version of cdt-lsp are you using? |
|
Is this what you are looking for: C:\Espressif\tools\esp-clang\16.0.1-fe4f10a809\esp-clang\bin\clangd.exe |
|
|
You are close: please type LSP. I need the version of the |
|
|
|
*** Date: Wednesday, 22 May 2024 at 14:12:25 British Summer Time *** Platform Details: *** System properties: *** System environment variables: *** Features: *** Plug-in Registry: *** User Preferences: *** Current Install Configuration: Id: com.espressif.idf.lsp, Version: 1.0.1.202405161213, Location: reference:file:/C:/Users/Steven/.p2/pool/plugins/com.espressif.idf.lsp_1.0.1.202405161213.jar *** Security Configuration: Service: KeyGenerator, Algorithm: SunTlsPrf, Class: com.sun.crypto.provider.TlsPrfGenerator$V10 |
|
@BenthamSoftwareServices this bug should be fixed by #321 . Can you please check if this issue has been fixed by testing it with the 2024-06 M3 release which comes later this week? |
|
Thanks @ghentschke for applying the fix.
@BenthamSoftwareServices If you aren't an Eclipse developer then the above request by me may have been a bit too much to ask - please check out the new build available Friday as @ghentschke mentioned in the above comment. That said, if you are using a vendor version of Eclipse you may need to contact the vendor to get an update. |
|
Closing this issue - the fix is pushed. Please comment or reopen if there is still something left to do here. |
|
I assume the patch is live now, how exactly should I apply it? |
|
I have installed 2024-06 and the problem I reported no longer occurs - thank you. |
Message windows appears = error.log
Error occurs when Launching any ESP-IDF project in Debug mode.
Eclipse IDE for Embedded C/C++ Developers (includes Incubating components)
Version: 2024-03 (4.31.0)
Build id: 20240307-1437
OS: Windows 11, v.10.0, x86_64 / win32
Java vendor: Eclipse Adoptium
Java runtime version: 17.0.11+9
Java version: 17.0.11
Using ESP-IDF v5.2.1
error.log
OKing the error message Window closes it and appears to have no effect on normal debugging operation. I would like to fix the source of the error, or, if that is not possible, supress it.
[x ] I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
The text was updated successfully, but these errors were encountered: