-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#36] Add new content provider using LSP #54
[#36] Add new content provider using LSP #54
Conversation
This is a first draft based on on a not yet stable LSP4E API. The content provider delivers the children of a ITranslationUnit when Currently the children consist of the symbols delivered by the LSP textDocument/documentSymbol command. They are identical to the outline view symbols from a document. Perspectiveley the includes and macros could be added and a new CModelBuilder should be implemented to get rid of the old internal AST based data model. |
This looks good @ghentschke I can try it out later. Does it need a specific LSP4E PR, or does it work with current master branch of LSP4E? |
This works with the current master of of LSP4E |
...t.lsp.editor.ui/src/org/eclipse/cdt/lsp/editor/ui/preference/LspEditorPreferencesTester.java
Outdated
Show resolved
Hide resolved
...s/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/ui/navigator/LspCEditorOpenActionProvider.java
Outdated
Show resolved
Hide resolved
...s/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/ui/navigator/LspCEditorOpenActionProvider.java
Outdated
Show resolved
Hide resolved
1f115c1
to
3473fc8
Compare
...s/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/ui/navigator/LspCEditorOpenActionProvider.java
Outdated
Show resolved
Hide resolved
...les/org.eclipse.cdt.lsp/src/org/eclipse/cdt/lsp/ui/navigator/CSymbolsOpenActionProvider.java
Outdated
Show resolved
Hide resolved
Uses the LSP to fetch the children of a TU in the project explorer view. fixes eclipse-cdt#36
3473fc8
to
1e8959d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for considering my comments @ghentschke
@ruspl-afed thank your for your very constructive review! |
Uses the LSP to fetch the children of a TU in the project explorer view.
fixes #36