[#132] Remove InitialUri interface and its usages #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `InitialUri` and use `UriResource` query
ghentschke
reviewed
Jun 15, 2023
| private IWorkspace workspace; | ||
|
|
||
| @Override | ||
| public FallbackFlags getFallbackFlagsFromInitialUri(URI root) { | ||
| if (isWindows) { | ||
| return uri.find(root)// | ||
| return Optional.ofNullable(root)// | ||
| .flatMap(new UriResource(workspace))// |
There was a problem hiding this comment.
This won't work since the rootURI form LSP4E is the URI of the initial project. We need the URI of the initial file.
We can apply the changes of this PR when LSP4E has accepted my PR #692
There was a problem hiding this comment.
We need the URI of the initial file.
Why IProject is not sufficient for us?
There was a problem hiding this comment.
As I can see it, what we do next is get IProject from IResource (or IFile), isn't it?
|
Became outdated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
InitialUriand useUriResourcequery