Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hide clangd property and preference pages #161

Merged
merged 1 commit into from Aug 5, 2023
Merged

Remove hide clangd property and preference pages #161

merged 1 commit into from Aug 5, 2023

Conversation

ghentschke
Copy link
Contributor

@ghentschke ghentschke commented Aug 3, 2023 •
edited

The hiding of the properties/preference page should be done by vendors and not in this plugin.

@ghentschke
Remove hide clangd property and preference pages
a80d616 
The hiding of the properties page should be done by vendors and not in
this plugin.
jonahgraham
jonahgraham approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hiding of the properties/preference page should be done by vendors and not in this plugin.

+1

@ghentschke ghentschke merged commit e8acd99 into eclipse-cdt:master Aug 5, 2023
3 checks passed
@ghentschke ghentschke deleted the remove-hide-prefs-props-page branch August 5, 2023 05:29
@jonahgraham jonahgraham added this to the 1.0.0 milestone Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahgraham jonahgraham jonahgraham approved these changes

@ruspl-afed ruspl-afed ruspl-afed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ghentschke @jonahgraham @ruspl-afed