Account for non-API method signature change in LSP4E #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of the LanguageServerWrapper restart method changed between the last two snapshots. This means we needed to remove our catch a few commits ago. This also means we need to use a version of LSP4E >= the version where the non-API changed, hence why we care about patch version in the MANIFEST.MF. We probably need to have LS4E expose needed methods as API so we don't have problems mixing and matching versions going forward. See the corresponding LSP4E commit: eclipse/lsp4e@a27b7a9 And the corresponding CDT-LSP commit that fixed the compilation issue: eclipse-cdt@6d6209b
|
Follow-up for #322 @ghentschke let me know what you think. This is slightly less important in SimRel, but quite important for people consuming the cdt-lsp repo directly to make sure they end up with a working pair of LSP4E and cdt-lsp. |
I fully agree. We have to discuss this with the LSP4E team to find a solution for this. We use several classes which are not public API. That's not very nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of the LanguageServerWrapper restart method changed between the last two snapshots. This means we needed to remove our catch a few commits ago. This also means we need to use a version of LSP4E >= the version where the non-API changed, hence why we care about patch version in the MANIFEST.MF.
We probably need to have LS4E expose needed methods as API so we don't have problems mixing and matching versions going forward.
See the corresponding LSP4E commit:
eclipse/lsp4e@a27b7a9
And the corresponding CDT-LSP commit that fixed the compilation issue:
6d6209b