Fix arithmetic conversion from larger unsigned operand type

Fixes: 16944a0 ("Arithmetic conversions for unary and binary expressions, bug 231859.") Closes: #265
eclipse-cdt · Feb 4, 2023 · 57008ba · 57008ba
1 parent cf834dd
commit 57008ba
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...clipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ArithmeticConversion.java b/...clipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/ArithmeticConversion.java
@@ -201,8 +201,8 @@ private final IType convert(IType type1, IType type2) {
 			return unsignedType;
 		}
 
-		// The signed has the higher rank.
-		if (signedRank.ordinal() > unsignedRank.ordinal()) {
+		// The signed has the higher rank, check if signed type can represent all unsigned values
+		if (fitsIntoType(signedType, unsignedType)) {
 			return signedType;
 		}