-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin dependency should always contain a version range #223
Comments
What version range do you have in mind? |
Well, the problem is that without a range and changing the BREE, there is nothing that downstream can do to ensure that the right plugin is installed. In my world, this is a serious break of the contract to the downstream vendors/users. |
Platform updgraded to Java 11 without changing major version and most probably will repeat this trick after move to Java 17, so version range will not help a lot.
This looks more like a p2 issue: p2 has all the information to analyze EE & BREE and reject to install. |
Just FYI this is documented and expected behavior for long time now https://wiki.eclipse.org/Version_Numbering#When_to_change_the_minor_segment . |
Thank you for this link @akurtakov , no idea why I was sure that BREE upgrade is API breaking change. |
This sounds like a p2 bug - i.e. that installing Bundles with BREE > than running Java should not be allowed. This is going to affect much more than just CDT as other things (like tracecompass, lsp4e, tm4e) also all have (or will soon have) BREE of Java 17, but no major version change. |
I think you are referring to the old discussion in ticket https://bugs.eclipse.org/bugs/show_bug.cgi?id=483383.
I know that there is the checkbox in the Window -> Preferences -> Install/Update, but checking that checkbox will have the consequence that it's not possible to upgrade to a new version that do require a newer version of the JRE even if the new JRE would be installed in the same p2 operation. When I wrote this issue, I was not aware that it was considered a "minor" bump for the BREE change. I personally think this is a mistake as there is simply no way to defend against the unwanted changes as a consumer of a bundle. |
Since the inclusion of the org.eclipse.tools.templates.* plugins in the CDT repository, the Required-Bundle statement was not updated to include the version range for the plugin that CDT now is providing.
As a consequence, the version of the plugin can be freely chosen as long as the minimum version requirement is fulfilled.
As there might be other plugins that CDT is now providing that is lacking the version range in Required-Bundle part of the MANIFEST.MF file, the org.eclipse.tools.templates mentioned above should only be taken as an example of the problem.
This issue is related to #222.
The text was updated successfully, but these errors were encountered: