Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XML whitespace clean up only #647

Closed
wants to merge 1 commit into from
Closed

Conversation

jld01
Copy link
Contributor

@jld01 jld01 commented Dec 14, 2023

Using HTML Tidy:

tidy --input-xml yes --output-xml yes --wrap 0 --indent yes --indent-spaces 3 --indent-attributes yes --sort-attributes alpha -modify plugin.xml

Relates to #646

@Bananeweizen
Copy link
Contributor

I'm not a CDT developer, but I would think twice about the sorting of attributes. At least I myself am used to finding the ID attribute as the first one, and that change would make this much harder.
Besides that, have you checked the behavior of the reformatting on multiline text string attributes? I haven't seen an example in the change, but I'm thinking of stuff like feature descriptions. As those are taken verbatim from the feature.xml, reformatting them with line wrapping or indentation always leads to end user visible changes. Similar fields might exist in plugin.xml (e.g. a perspective description).

@jld01
Copy link
Contributor Author

jld01 commented May 27, 2024

Abandoning this PR in favour of one-off formatting using Eclipse IDE (#801).

@jld01 jld01 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants