Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection for VS 2022 toolchain #778

Merged
merged 2 commits into from May 15, 2024
Merged

Conversation

MarkZ3
Copy link
Contributor

@MarkZ3 MarkZ3 commented May 10, 2024

This adds basic support for VS 2022 by detecting the toolchain. I.e. include paths, lib paths, and PATH env var are properly detected.

The detection works the same as 2017 and 2019 since vswhere.exe works the same and the folder layout hasn't changed.

Revived from https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/182202

@jonahgraham
Copy link
Member

I assume build is failing because of #780 - I'll try to solve the immediate issue soon.

This adds basic support for VS 2022 by detecting the toolchain.
I.e. include paths, lib paths, and PATH env var are properly detected.

The detection works the same as 2017 and 2019 since vswhere.exe works
the same and the folder layout hasn't changed.

Revived from https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/182202
Copy link
Member

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased - once builds passed anyone can merge. (Maybe time to look at enabling auto-merge for CDT?)

@jonahgraham
Copy link
Member

My code to ensure feature copyrights are up to date is confused by the authored date being in the past. I'll need to revisit

feature_end_year=$(git log --format='%ad' --date="format:%Y" -- $feature_xml $plugin_dir | head -1)

or maybe just disable it. Sorry that another process issue is getting in the way of a simple code change.

@jonahgraham jonahgraham merged commit 237c326 into eclipse-cdt:main May 15, 2024
4 of 5 checks passed
@MarkZ3
Copy link
Contributor Author

MarkZ3 commented May 16, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants