fix: destroy request in case of error (#1107)

* fix: destroy request in case of error Signed-off-by: Anatolii Bazko <abazko@redhat.com> * fixup Signed-off-by: Anatolii Bazko <abazko@redhat.com> --------- Signed-off-by: Anatolii Bazko <abazko@redhat.com>
eclipse-che · May 13, 2024 · 9834cd4 · 9834cd4
1 parent 0125fb5
commit 9834cd4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/dashboard-backend/src/devworkspaceClient/services/devWorkspaceApi.ts b/packages/dashboard-backend/src/devworkspaceClient/services/devWorkspaceApi.ts
@@ -191,6 +191,7 @@ export class DevWorkspaceApiService implements IDevWorkspaceApi {
       },
       (error: unknown) => {
         logger.warn(error, `Stopped watching ${path}.`);
+        request.destroy();
       },
     );
 

diff --git a/packages/dashboard-backend/src/devworkspaceClient/services/eventApi.ts b/packages/dashboard-backend/src/devworkspaceClient/services/eventApi.ts
@@ -60,7 +60,10 @@ export class EventApiService implements IEventApi {
       queryParams,
       (eventPhase: string, apiObj: CoreV1Event | V1Status) =>
         this.handleWatchMessage(eventPhase, apiObj, listener, params),
-      (error: unknown) => this.handleWatchError(error, path),
+      (error: unknown) => {
+        this.handleWatchError(error, path);
+        request.destroy();
+      },
     );
 
     this.stopWatch = () => request.destroy();

diff --git a/packages/dashboard-backend/src/devworkspaceClient/services/podApi.ts b/packages/dashboard-backend/src/devworkspaceClient/services/podApi.ts
@@ -60,7 +60,10 @@ export class PodApiService implements IPodApi {
       queryParams,
       (eventPhase: string, apiObj: V1Pod | V1Status) =>
         this.handleWatchMessage(eventPhase, apiObj, listener, params),
-      (error: unknown) => this.handleWatchError(error, path),
+      (error: unknown) => {
+        this.handleWatchError(error, path);
+        request.destroy();
+      },
     );
 
     this.stopWatch = () => request.destroy();