Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update che-devworkspace-generator in yarn.lock #1040

Closed
wants to merge 1 commit into from

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented Jan 15, 2024

What does this PR do?

Reran yarn install to rebuilt the yarn.lock file to include latest devworkspace-generator release.
There are lint errors...

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-5452

@che-bot
Copy link
Contributor

che-bot commented Jan 15, 2024

Click here to review and test in web IDE: Contribute

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please open PR from origin, not fork, to make the PR checks happy

Copy link
Contributor

@akurinnoy akurinnoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, SDawley

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SDawley
Copy link
Contributor Author

SDawley commented Jan 16, 2024

Closing in favor of #1041

@ibuziuk ibuziuk closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants