Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/nodejs-18:1-86 to ubi8/nodejs-18:1-102 #1100

Closed
wants to merge 1 commit into from

Conversation

che-bot
Copy link
Contributor

@che-bot che-bot commented Apr 20, 2024

Signed-off-by: Nick Boldt nboldt@redhat.com

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci-robot
Copy link

@che-bot: No Jira issue with key nodejs-18 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Signed-off-by: Nick Boldt nboldt@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@che-bot
Copy link
Contributor Author

che-bot commented Apr 20, 2024

Click here to review and test in web IDE: Contribute

Copy link

openshift-ci bot commented Apr 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: che-bot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1100

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1100", name: che-dashboard}]}}]"

@@ -20,7 +20,7 @@ RUN npm i -g yarn; yarn install
RUN yarn build

# https://registry.access.redhat.com/ubi8/nodejs-18
FROM registry.access.redhat.com/ubi8/nodejs-18:1-86
FROM registry.access.redhat.com/ubi8/nodejs-18:1-102

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good !!!

@akurinnoy
Copy link
Contributor

@nickboldt I'm wondering if the brew.Dockerfile needs to be updated.

@nickboldt
Copy link
Contributor

@nickboldt I'm wondering if the brew.Dockerfile needs to be updated.

Sounds like a question for @mkuznyetsov or @SDawley

@olexii4
Copy link
Contributor

olexii4 commented May 27, 2024

Fixed with #1115

@olexii4 olexii4 closed this May 27, 2024
@olexii4 olexii4 deleted the pr-update-base-images-1713571432 branch May 27, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants