Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update from ubi8/nodejs-18:1-86 to ubi8/nodejs-18:1-102 #1103

Closed
wants to merge 1 commit into from

Conversation

che-bot
Copy link
Contributor

@che-bot che-bot commented Apr 27, 2024

Signed-off-by: Nick Boldt nboldt@redhat.com

Signed-off-by: Nick Boldt <nboldt@redhat.com>
@openshift-ci-robot
Copy link

@che-bot: No Jira issue with key nodejs-18 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Signed-off-by: Nick Boldt nboldt@redhat.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Apr 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: che-bot

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor Author

che-bot commented Apr 27, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1103

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1103", name: che-dashboard}]}}]"

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (585302c) to head (9577568).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
+ Coverage   88.91%   89.13%   +0.22%     
==========================================
  Files         400      400              
  Lines       40705    40705              
  Branches     2692     2711      +19     
==========================================
+ Hits        36194    36284      +90     
+ Misses       4482     4395      -87     
+ Partials       29       26       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4
Copy link
Contributor

olexii4 commented May 27, 2024

Fixed with #1115

@olexii4 olexii4 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants