Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the regular expression for SSH URLs #1130

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: the regular expression for SSH URLs #1130

merged 1 commit into from
Jun 27, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 12, 2024

What does this PR do?

This PR fixes the regular expression for SSH URLs.

What issues does this PR fix or reference?

fixes https://issues.redhat.com/browse/CRW-6566

Знімок екрана 2024-06-12 о 16 02 54

Знімок екрана 2024-06-12 о 16 05 36

@che-bot
Copy link
Contributor

che-bot commented Jun 12, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1130

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1130", name: che-dashboard}]}}]"

1 similar comment
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1130

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1130", name: che-dashboard}]}}]"

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1130

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1130", name: che-dashboard}]}}]"

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.68%. Comparing base (28abf62) to head (e4c2fae).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   89.61%   89.68%   +0.07%     
==========================================
  Files         411      411              
  Lines       41920    41923       +3     
  Branches     2809     2817       +8     
==========================================
+ Hits        37566    37600      +34     
+ Misses       4329     4298      -31     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexii4 olexii4 marked this pull request as draft June 14, 2024 00:49
@olexii4 olexii4 marked this pull request as ready for review June 27, 2024 07:45
Copy link

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 03adeb1 into main Jun 27, 2024
18 checks passed
@olexii4 olexii4 deleted the CRW-6566 branch June 27, 2024 09:00
@devstudio-release
Copy link

Build 3.15 :: dashboard_3.15/1: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/502: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: dashboard_3.x/502: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/6972 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.16 :: get-sources-rhpkg-container-build_3.x/6921: FAILURE

devspaces-operator-bundle : 3.x :: Failed in 62233603 : BREW:BUILD/STATUS:UNKNOWN
FAILURE:; copied to quay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants