-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the regular expression for SSH URLs #1130
Conversation
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1130 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1130", name: che-dashboard}]}}]" |
1 similar comment
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1130 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1130", name: che-dashboard}]}}]" |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1130 kubectl patch commandkubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1130", name: che-dashboard}]}}]" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
+ Coverage 89.61% 89.68% +0.07%
==========================================
Files 411 411
Lines 41920 41923 +3
Branches 2809 2817 +8
==========================================
+ Hits 37566 37600 +34
+ Misses 4329 4298 -31
Partials 25 25 ☔ View full report in Codecov by Sentry. |
packages/dashboard-frontend/src/services/factory-location-adapter/index.ts
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.15 :: dashboard_3.15/1: Console, Changes, Git Data |
Build 3.16 :: dashboard_3.x/502: Console, Changes, Git Data |
Build 3.15 :: sync-to-downstream_3.15/4: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/6972: Console, Changes, Git Data |
Build 3.16 :: push-latest-container-to-quay_3.x/4692: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/6920: dashboard : 3.x :: Build 62233440 : quay.io/devspaces/dashboard-rhel8:3.16-1 |
Build 3.16 :: update-digests_3.x/6886: Console, Changes, Git Data |
Build 3.16 :: dashboard_3.x/502: Upstream sync done; /DS_CI/sync-to-downstream_3.x/6972 triggered |
Build 3.16 :: operator-bundle_3.x/3122: Console, Changes, Git Data |
Build 3.16 :: sync-to-downstream_3.x/6973: Console, Changes, Git Data |
Build 3.16 :: get-sources-rhpkg-container-build_3.x/6921: devspaces-operator-bundle : 3.x :: Failed in 62233603 : BREW:BUILD/STATUS:UNKNOWN |
What does this PR do?
This PR fixes the regular expression for SSH URLs.
What issues does this PR fix or reference?
fixes https://issues.redhat.com/browse/CRW-6566