Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump devfile/api to 2.3.0; bump devworkspace generator #1156

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

svor
Copy link
Contributor

@svor svor commented Jul 31, 2024

What does this PR do?

  • Upgrade devfile/api to 2.3.0 version
  • Upgrade devworkspace generator tool to 7.89.0-next-784dff2

What issues does this PR fix or reference?

eclipse-che/che#23041

Is it tested? How?

  • check Build PR check
  • patch OS cluster with final image and try to start a workspace

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor self-assigned this Jul 31, 2024
@che-bot
Copy link
Contributor

che-bot commented Jul 31, 2024

Click here to review and test in web IDE: Contribute

Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1156

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1156", name: che-dashboard}]}}]"

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (b8be17e) to head (444aba1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1156      +/-   ##
==========================================
- Coverage   89.67%   89.43%   -0.25%     
==========================================
  Files         415      415              
  Lines       42461    42461              
  Branches     2843     2837       -6     
==========================================
- Hits        38077    37975     -102     
- Misses       4357     4458     +101     
- Partials       27       28       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1156

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1156", name: che-dashboard}]}}]"

Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1156

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1156", name: che-dashboard}]}}]"

Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk, svor

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants