Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use 3rd party library for devfile converter #413

Merged
merged 1 commit into from Nov 30, 2021
Merged

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Nov 30, 2021

What does this PR do?

Use 3rd party library for devfile converter

What issues does this PR fix or reference?

Fixes eclipse-che/che#20843
Fixes https://issues.redhat.com/browse/CRW-2492
Fixes https://issues.redhat.com/browse/CRW-2493

Is it tested? How?

Start with http://che-host#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 on a che-server installation without devWorkspace engine

You can see that compared to before:

  • java plug-in is there
  • commands are using CHE_PROJECTS_ROOT (and not PROJECTS_ROOT)
  • mountSources: true is there on components

Release Notes

Docs PR

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #413 (80f3071) into main (f1963af) will increase coverage by 0.04%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   49.41%   49.45%   +0.04%     
==========================================
  Files         208      207       -1     
  Lines        7328     7192     -136     
  Branches     1242     1189      -53     
==========================================
- Hits         3621     3557      -64     
+ Misses       3327     3291      -36     
+ Partials      380      344      -36     
Impacted Files Coverage Δ
...rd-frontend/src/containers/FactoryLoader/index.tsx 72.69% <80.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1963af...80f3071. Read the comment docs.

@benoitf
Copy link
Contributor Author

benoitf commented Nov 30, 2021

I'm looking into the dash issue

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-413

@che-bot
Copy link
Contributor

che-bot commented Nov 30, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@benoitf
Copy link
Contributor Author

benoitf commented Nov 30, 2021

it seems dash-license check is failing due to che-incubator/dash-licenses@1d2d6cb and not related to my PR

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-413

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, benoitf, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Nov 30, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@benoitf benoitf merged commit e6aaa23 into main Nov 30, 2021
@benoitf benoitf deleted the CHE-20843 branch November 30, 2021 11:06
@che-bot che-bot added this to the 7.40 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants