New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use 3rd party library for devfile converter #413
Conversation
Codecov Report
@@ Coverage Diff @@
## main #413 +/- ##
==========================================
+ Coverage 49.41% 49.45% +0.04%
==========================================
Files 208 207 -1
Lines 7328 7192 -136
Branches 1242 1189 -53
==========================================
- Hits 3621 3557 -64
+ Misses 3327 3291 -36
+ Partials 380 344 -36
Continue to review full report at Codecov.
|
I'm looking into the dash issue |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-413 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
it seems dash-license check is failing due to che-incubator/dash-licenses@1d2d6cb and not related to my PR |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-413 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, benoitf, ibuziuk, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
What does this PR do?
Use 3rd party library for devfile converter
What issues does this PR fix or reference?
Fixes eclipse-che/che#20843
Fixes https://issues.redhat.com/browse/CRW-2492
Fixes https://issues.redhat.com/browse/CRW-2493
Is it tested? How?
Start with http://che-host#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 on a che-server installation without devWorkspace engine
You can see that compared to before:
Release Notes
Docs PR