Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default policy and add ?new for starting a new workspace using short syntax #417

Merged
merged 2 commits into from Dec 7, 2021

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Dec 2, 2021

What does this PR do?

*only for devWorkspace mode Change default policy to only create only one workspace when we click on a link

To create a new workspace, allow to use ?new at the end of the short URL

ie:

http://che-server#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 : only one workspace
http://che-server#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?new ==> create a new workspace

What issues does this PR fix or reference?

fixes eclipse-che/che#20867

Is it tested? How?

yes clicking first
http://localhost:3000#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2

then clicking on http://localhost:3000#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 is reopening the same workspace

and http://localhost:3000#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?new is creating a new one

Release Notes

Docs PR

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #417 (982df99) into main (d60de97) will increase coverage by 0.16%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   49.40%   49.57%   +0.16%     
==========================================
  Files         210      210              
  Lines        7232     7240       +8     
  Branches     1194     1198       +4     
==========================================
+ Hits         3573     3589      +16     
+ Misses       3315     3311       -4     
+ Partials      344      340       -4     
Impacted Files Coverage Δ
...ashboard-frontend/src/services/helpers/location.ts 95.16% <83.33%> (+11.23%) ⬆️
...rd-frontend/src/containers/FactoryLoader/index.tsx 73.59% <100.00%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60de97...982df99. Read the comment docs.

@github-actions

This comment has been minimized.

@che-bot

This comment has been minimized.

@akurinnoy
Copy link
Contributor

It would be great to have this feature documented if it hasn't been done yet.

@benoitf
Copy link
Contributor Author

benoitf commented Dec 2, 2021

@akurinnoy yes 👍
I'm working on documentation for https://issues.redhat.com/browse/RHDEVDOCS-3505 this is why I created this PR

@benoitf benoitf marked this pull request as draft December 3, 2021 14:50
@benoitf benoitf changed the title feat: allow to specify policy creation in short form syntax feat: change default policy and add ?new for starting a new workspace using short syntax Dec 3, 2021
Try to open again a workspace by default
Creates a new workspace if specify ?new at the end of short URL

Note: it applies only for DevWorkspaces
fix eclipse-che/che#20867
@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-417

@che-bot
Copy link
Contributor

che-bot commented Dec 6, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2021
Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it and it is working as expected. But it is not convenient to use the "Import from git" widget for adding some additional param.
My proposal: we could add a check under the input field:
2021-12-06_12_08_32
WDYT?

@openshift-ci

This comment has been minimized.

…n again a workspace by default Creates a new workspace if specify ?new at the end of short URL
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Dec 6, 2021
@che-bot
Copy link
Contributor

che-bot commented Dec 6, 2021

✅ E2E dashboard tests succeed 🎉

See Details

Test product:

  • Use comment "[dashboard-ci-test]" to rerun the dashboard e2e tests

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-417

@benoitf
Copy link
Contributor Author

benoitf commented Dec 7, 2021

merging.
Oleksii: I saw your comment about the checkbox but I'm still unsure people will want to create a new workspace by copying/pasting the link again and again
Let see the feedback we receive and then revisit the layout.

@benoitf benoitf merged commit f304883 into main Dec 7, 2021
@benoitf benoitf deleted the CHE-20867 branch December 7, 2021 14:19
@che-bot che-bot added this to the 7.41 milestone Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants