New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change default policy and add ?new for starting a new workspace using short syntax #417
Conversation
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 49.40% 49.57% +0.16%
==========================================
Files 210 210
Lines 7232 7240 +8
Branches 1194 1198 +4
==========================================
+ Hits 3573 3589 +16
+ Misses 3315 3311 -4
+ Partials 344 340 -4
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
It would be great to have this feature documented if it hasn't been done yet. |
@akurinnoy yes 👍 |
Try to open again a workspace by default Creates a new workspace if specify ?new at the end of short URL Note: it applies only for DevWorkspaces fix eclipse-che/che#20867
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-417 |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
packages/dashboard-frontend/src/containers/__tests__/FactoryLoader.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment has been minimized.
This comment has been minimized.
…n again a workspace by default Creates a new workspace if specify ?new at the end of short URL
New changes are detected. LGTM label has been removed. |
✅ E2E dashboard tests succeed 🎉 See Details
Test product:
Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe |
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-417 |
merging. |
What does this PR do?
*only for devWorkspace mode Change default policy to only create only one workspace when we click on a link
To create a new workspace, allow to use
?new
at the end of the short URLie:
What issues does this PR fix or reference?
fixes eclipse-che/che#20867
Is it tested? How?
yes clicking first
http://localhost:3000#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2
then clicking on http://localhost:3000#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2 is reopening the same workspace
and http://localhost:3000#https://github.com/che-samples/java-spring-petclinic/tree/devfilev2?new is creating a new one
Release Notes
Docs PR