Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show a warning banner by configuring CheCluster CR (#466) #478

Merged
merged 6 commits into from Mar 16, 2022

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Mar 14, 2022

Backporting eclipse-che/che#20724 to 7.42.x

PR contains a number of commits to make the warning header functionality work as expected. Verified against the che-dev dogfooding instance:

image

@openshift-ci
Copy link

openshift-ci bot commented Mar 14, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

olexii4 and others added 4 commits March 14, 2022 17:44
* upgrade devfile-converter

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* feat: upgrade vulnerable libraries

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* feat: fix local start flow

Signed-off-by: Oleksii Orel <oorel@redhat.com>

* fix: remove Keycloak's part from README

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Signed-off-by: Oleksii Orel <oorel@redhat.com>
* feat: using SERVICE ACCOUNT token for access to Custom Resources

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@ibuziuk ibuziuk marked this pull request as ready for review March 14, 2022 17:03
@ibuziuk ibuziuk mentioned this pull request Mar 14, 2022
35 tasks
@ibuziuk ibuziuk changed the title [Draft] Add ability to show a warning banner by configuring CheCluster CR (#466) Add ability to show a warning banner by configuring CheCluster CR (#466) Mar 14, 2022
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478

@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 15, 2022

@olexii4 thanks for the review, just wondering about the removal of the packages/dashboard-backend/src/services/kubeclient/keycloak.ts will it affect the che-server-based setup / CRW 2.15.3? I verified only against che-dev cluster with DevWorkspace engine enabled by default and spinning the cluster bot with CRW 2.15.2 atm to make sure that it will work as expected.

@openshift-ci openshift-ci bot removed the lgtm label Mar 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2022

New changes are detected. LGTM label has been removed.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478

@nickboldt
Copy link
Contributor

Yikes, that's a lot of changes. Some seem unrelated... like removing stuff about keycloak?

@nickboldt
Copy link
Contributor

Where is the displayed message & link configured? I scrolled the whole PR but got lost in a typescript haze, didn't see any mention of a blog post or whatnot.

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 15, 2022

the message will be configured on the codeready-worskapces-operator defaults for spec.dashboard.warning

@nickboldt
Copy link
Contributor

nickboldt commented Mar 15, 2022

We can add / change annotations in https://github.com/redhat-developer/devspaces-images/blob/devspaces-3-rhel-8/codeready-workspaces-operator/build/scripts/sync-che-operator-to-crw-operator.sh#L249-L258 when transforming upstream Che Operator into Dev Spaces Operator

Once you have a sample bit o' text to inject there, please throw me a PR for the above repo and we can verify it's appearing in DS 3 (but not in Che 7.44)

@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 16, 2022

@nickboldt the PR for the operator has been merged - eclipse-che/che-operator#1339
from the downstream operator perspective please provide the default value for spec.dashboard.warning it could be lorem ipsum for now

@olexii4
Copy link
Contributor

olexii4 commented Mar 16, 2022

@ibuziuk I have returned packages/dashboard-backend/src/services/kubeclient/keycloak.ts back(commit).

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-478

@ibuziuk ibuziuk merged commit 9961738 into 7.42.x Mar 16, 2022
@ibuziuk ibuziuk deleted the che-20724 branch March 16, 2022 14:44
@che-bot che-bot added this to the 7.42 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants