fix: add registries and dashboard url to all containers #522
Conversation
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-522 |
|
when merged, we need this cherrypicked to 7.46.x too |
There was a problem hiding this comment.
@akurinnoy could you please clarify if the problem is reproducible for you on dogfooding? I can not reproduce atm via #https://raw.githubusercontent.com/eclipse-che/che-operator/main/devfile.yaml for example. All the env vars seem to be propagated properly even without this fix 🤷
UPDATE: however after restart those env vars are disappearing!
packages/dashboard-frontend/src/services/workspace-client/devworkspace/devWorkspaceClient.ts
Show resolved
Hide resolved
packages/dashboard-frontend/src/services/workspace-client/devworkspace/devWorkspaceClient.ts
Show resolved
Hide resolved
|
Click here to review and test in web IDE: |
Codecov Report
@@ Coverage Diff @@
## main #522 +/- ##
==========================================
+ Coverage 54.66% 54.69% +0.03%
==========================================
Files 235 235
Lines 8088 8098 +10
Branches 1393 1397 +4
==========================================
+ Hits 4421 4429 +8
- Misses 3448 3450 +2
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-522 |
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-522 |
|
@akurinnoy: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, olexii4 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix: add registries and dashboard url to all containers * fixup! fix: add registries and dashboard url to all containers * fixup! fixup! fix: add registries and dashboard url to all containers * fix: update dependencies list * fixup! fixup! fixup! fix: add registries and dashboard url to all containers
What does this PR do?
Add environment variables to all the DevWorkspace and DevWorkspaceTemplate containers
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-2964