Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to select an alternative editor from the UD #575

Merged
merged 3 commits into from
Jul 19, 2022

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jul 13, 2022

Signed-off-by: Oleksii Orel oorel@redhat.com

What does this PR do?

Added the ability to select an alternative editor from the dashboard.

What issues does this PR fix or reference?

fixes eclipse-che/che#20627

Знімок екрана 2022-07-13 о 13 57 18

@olexii4 olexii4 requested a review from ibuziuk July 13, 2022 11:23
@olexii4 olexii4 requested a review from akurinnoy as a code owner July 13, 2022 11:23
@che-bot
Copy link
Contributor

che-bot commented Jul 13, 2022

Click here to review and test in web IDE: Contribute

1 similar comment
@che-bot
Copy link
Contributor

che-bot commented Jul 13, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-575

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #575 (9ca0440) into main (aeb69fc) will decrease coverage by 0.13%.
The diff coverage is 46.26%.

❗ Current head 9ca0440 differs from pull request most recent head d96b071. Consider uploading reports for the commit d96b071 to get more accurate results

@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
- Coverage   56.16%   56.03%   -0.14%     
==========================================
  Files         219      220       +1     
  Lines        7449     7504      +55     
  Branches     1273     1281       +8     
==========================================
+ Hits         4184     4205      +21     
- Misses       3080     3113      +33     
- Partials      185      186       +1     
Flag Coverage Δ
unittests 56.03% <46.26%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rd-frontend/src/components/DevfileEditor/index.tsx 27.95% <ø> (-0.39%) ⬇️
...es/GetStarted/GetStartedTab/SamplesListGallery.tsx 61.25% <28.00%> (-13.33%) ⬇️
...ges/GetStarted/GetStartedTab/DropdownItemGroup.tsx 44.44% <44.44%> (ø)
.../src/pages/GetStarted/GetStartedTab/SampleCard.tsx 66.66% <50.00%> (-33.34%) ⬇️
...rontend/src/Layout/Header/Tools/UserMenu/index.tsx 83.33% <100.00%> (ø)
...WorkspaceDetails/Header/Actions/Dropdown/index.tsx 92.85% <100.00%> (ø)
...frontend/src/store/Plugins/chePlugins/selectors.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb69fc...d96b071. Read the comment docs.

…board

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jul 15, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-575

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job, works like a charm against dogfooding 👍
Let's wait for UX approval before merging

@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2022

@olexii4: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path d96b071 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@beaumorley
Copy link

Looks great!

@openshift-ci openshift-ci bot removed the lgtm label Jul 19, 2022
@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2022

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Jul 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 19, 2022

New changes are detected. LGTM label has been removed.

@che-bot
Copy link
Contributor

che-bot commented Jul 19, 2022

Click here to review and test in web IDE: Contribute

@olexii4 olexii4 merged commit 987e1d0 into main Jul 19, 2022
@olexii4 olexii4 deleted the CHE-20627 branch July 19, 2022 14:08
@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-575

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-575

@che-bot che-bot added this to the 7.51 milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants