Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "Events" tab #708

Merged
merged 18 commits into from
Feb 8, 2023
Merged

feat: add "Events" tab #708

merged 18 commits into from
Feb 8, 2023

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

This PR adds the Events tab to the workspaces startup page and the workspace details page.

Demo

Running a workspace in background

Running a workspace in background video

https://youtu.be/-64-YFHmbRw

Starting a new workspace

Starting a new workspace video

https://youtu.be/32cC7eq4t6o

What issues does this PR fix or reference?

resolves eclipse-che/che#21825

Is it tested? How?

Release Notes

Docs PR

@openshift-ci
Copy link

openshift-ci bot commented Jan 20, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@che-bot
Copy link
Contributor

che-bot commented Jan 20, 2023

Click here to review and test in web IDE: Contribute

@akurinnoy akurinnoy self-assigned this Jan 20, 2023
@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2023

Click here to review and test in web IDE: Contribute

2 similar comments
@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Jan 23, 2023

Click here to review and test in web IDE: Contribute

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@12e6579). Click here to learn what that means.
The diff coverage is 80.17%.

❗ Current head b9ee2c5 differs from pull request most recent head b7f7939. Consider uploading reports for the commit b7f7939 to get more accurate results

@@           Coverage Diff           @@
##             main     #708   +/-   ##
=======================================
  Coverage        ?   77.04%           
=======================================
  Files           ?      320           
  Lines           ?    31370           
  Branches        ?     1836           
=======================================
  Hits            ?    24170           
  Misses          ?     7151           
  Partials        ?       49           
Flag Coverage Δ
unittests 77.04% <80.17%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/dashboard-backend/src/services/types/Observer.ts 0.00% <0.00%> (ø)
...dashboard-frontend/src/services/bootstrap/index.ts 0.00% <0.00%> (ø)
...orkspace-client/cheworkspace/cheWorkspaceClient.ts 100.00% <ø> (ø)
...s/dashboard-frontend/src/store/Workspaces/index.ts 53.16% <ø> (ø)
...shboard-frontend/src/store/Workspaces/selectors.ts 67.92% <ø> (ø)
packages/dashboard-frontend/src/store/index.ts 0.00% <0.00%> (ø)
...ages/dashboard-backend/src/routes/api/websocket.ts 20.47% <20.47%> (ø)
...src/devworkspaceClient/services/devWorkspaceApi.ts 64.78% <34.21%> (ø)
...ackend/src/devworkspaceClient/services/eventApi.ts 45.45% <45.45%> (ø)
...-backend/src/devworkspaceClient/services/podAPI.ts 45.45% <45.45%> (ø)
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-708

@che-bot
Copy link
Contributor

che-bot commented Feb 1, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-708

@che-bot
Copy link
Contributor

che-bot commented Feb 1, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-708

@che-bot
Copy link
Contributor

che-bot commented Feb 6, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-708

@che-bot
Copy link
Contributor

che-bot commented Feb 6, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2023

Click here to review and test in web IDE: Contribute

@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2023

Click here to review and test in web IDE: Contribute

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 7, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-708

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great!

image

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Feb 8, 2023
@che-bot
Copy link
Contributor

che-bot commented Feb 8, 2023

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@olexii4 olexii4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-708

@openshift-ci
Copy link

openshift-ci bot commented Feb 8, 2023

@akurinnoy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v11-dashboard-happy-path b7f7939 link true /test v11-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@akurinnoy akurinnoy merged commit eb5654a into main Feb 8, 2023
@akurinnoy akurinnoy deleted the workspace-events-tab branch February 8, 2023 13:57
@devstudio-release
Copy link

Build 3.6 :: dashboard_3.x/191: Console, Changes, Git Data

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants