Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workspace URL parameters after the user accepts the OAuth authorization #973

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Nov 2, 2023

What does this PR do?

Fix workspace URL parameters after the user accepts the OAuth authorization.

What issues does this PR fix or reference?

fixes https://issues.redhat.com/browse/CRW-4955

Is it tested? How?

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Nov 2, 2023

Click here to review and test in web IDE: Contribute

Copy link

github-actions bot commented Nov 2, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-973

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #973 (c996a82) into main (c2295c4) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #973      +/-   ##
==========================================
- Coverage   85.17%   85.16%   -0.02%     
==========================================
  Files         380      380              
  Lines       39176    39181       +5     
  Branches     2519     2520       +1     
==========================================
- Hits        33369    33368       -1     
- Misses       5780     5786       +6     
  Partials       27       27              
Flag Coverage Δ
unittests 85.16% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rd-backend/src/routes/factoryAcceptanceRedirect.ts 87.50% <66.66%> (-12.50%) ⬇️

Copy link
Contributor

@tolusha tolusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works as expected.

Copy link

github-actions bot commented Nov 3, 2023

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-973

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmytro-ndp we also need your approval before merging

Copy link

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@olexii4 olexii4 merged commit 2b636eb into main Nov 3, 2023
14 of 16 checks passed
@olexii4 olexii4 deleted the CRW-4955 branch November 3, 2023 14:25
@devstudio-release
Copy link

Build 3.10 :: dashboard_3.10/13: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/385: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@dmytro-ndp
Copy link
Contributor

PR has been verified successfully following "Steps to Reproduce" from https://issues.redhat.com/browse/CRW-4955
Test screenshot: https://youtu.be/i0xoktfXQTc

Good job, @olexii4 !

olexii4 added a commit that referenced this pull request Nov 3, 2023
…ization (#973)

* fix: workspace URL parameters after the user accepts OAuth authorization

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@devstudio-release
Copy link

olexii4 added a commit that referenced this pull request Nov 3, 2023
…ization (#973)

* fix: workspace URL parameters after the user accepts OAuth authorization

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.11 :: dashboard_3.x/385: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5161 triggered

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.10/93: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dashboard_3.10/13: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.10/89 triggered

@devstudio-release
Copy link

@devstudio-release
Copy link

olexii4 added a commit that referenced this pull request Nov 3, 2023
…ization (#973)

* fix: workspace URL parameters after the user accepts OAuth authorization

Signed-off-by: Oleksii Orel <oorel@redhat.com>
@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: sync-to-downstream_3.10/90: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.10/89 triggered; /job/DS_CI/job/dsc_3.10 triggered;

@devstudio-release
Copy link

Build 3.10 :: operator-bundle_3.10/31: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.10/90 triggered

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/2077: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Build 3.10 :: dsc_3.10/23: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: update-digests_3.10/93: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.10/31 triggered

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2078: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.11 :: sync-to-downstream_3.x/5162: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5049 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.11 :: operator-bundle_3.x/2250: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/5162 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1517: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.10 :: dsc_3.10/23: SUCCESS

3.10.0-CI

@devstudio-release
Copy link

Build 3.11 :: update-digests_3.x/4787: SUCCESS

Detected new images: rebuild operator-bundle
* dashboard; /DS_CI/operator-bundle_3.x/2250 triggered

@devstudio-release
Copy link

Build 3.11 :: dsc_3.x/1517: SUCCESS

3.11.0-CI

@devstudio-release
Copy link

Build 3.10 :: copyIIBsToQuay/2077: SUCCESS

3.10
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.10-187
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-614330-533291-s390x
  + quay.io/devspaces/iib:3.10-v4.14-s390x
  + quay.io/devspaces/iib:next-v4.14-s390x
  + quay.io/devspaces/iib:3.10-v4.13-614916-533286-s390x
  + quay.io/devspaces/iib:3.10-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.10-v4.12-614910-533281-s390x
  + quay.io/devspaces/iib:3.10-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.10-v4.11-614899-533277-s390x
  + quay.io/devspaces/iib:3.10-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-614330-533291-x86_64
  + quay.io/devspaces/iib:3.10-v4.14-x86_64
  + quay.io/devspaces/iib:next-v4.14-x86_64
  + quay.io/devspaces/iib:3.10-v4.13-614916-533286-x86_64
  + quay.io/devspaces/iib:3.10-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-614910-533281-x86_64
  + quay.io/devspaces/iib:3.10-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-614899-533277-x86_64
  + quay.io/devspaces/iib:3.10-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.10-v4.14-614923-533291-ppc64le
  + quay.io/devspaces/iib:3.10-v4.14-ppc64le
  + quay.io/devspaces/iib:next-v4.14-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-614916-533286-ppc64le
  + quay.io/devspaces/iib:3.10-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-614910-533281-ppc64le
  + quay.io/devspaces/iib:3.10-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-614899-533277-ppc64le
  + quay.io/devspaces/iib:3.10-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le

@devstudio-release
Copy link

Build 3.11 :: copyIIBsToQuay/2078: SUCCESS

3.11
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.11-25
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:0.21-7
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-614509-533291-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.14-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-614922-533286-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-x86_64
  + quay.io/devspaces/iib:3.11-v4.13-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-614915-533281-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-x86_64
  + quay.io/devspaces/iib:3.11-v4.12-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-614909-533277-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-x86_64
  + quay.io/devspaces/iib:3.11-v4.11-x86_64
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-614509-533291-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.14-s390x
  + quay.io/devspaces/iib:3.11-v4.13-614922-533286-s390x
  + quay.io/devspaces/iib:3.11-v4.13-s390x
  + quay.io/devspaces/iib:3.11-v4.13-s390x
  + quay.io/devspaces/iib:3.11-v4.12-614915-533281-s390x
  + quay.io/devspaces/iib:3.11-v4.12-s390x
  + quay.io/devspaces/iib:3.11-v4.12-s390x
  + quay.io/devspaces/iib:3.11-v4.11-614909-533277-s390x
  + quay.io/devspaces/iib:3.11-v4.11-s390x
  + quay.io/devspaces/iib:3.11-v4.11-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.11-v4.14-614926-533291-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.14-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-614922-533286-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-ppc64le
  + quay.io/devspaces/iib:3.11-v4.13-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-614915-533281-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-ppc64le
  + quay.io/devspaces/iib:3.11-v4.12-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-614909-533277-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-ppc64le
  + quay.io/devspaces/iib:3.11-v4.11-ppc64le

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants