-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workspace URL parameters after the user accepts the OAuth authorization #973
Conversation
Signed-off-by: Oleksii Orel <oorel@redhat.com>
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-973 |
Codecov Report
@@ Coverage Diff @@
## main #973 +/- ##
==========================================
- Coverage 85.17% 85.16% -0.02%
==========================================
Files 380 380
Lines 39176 39181 +5
Branches 2519 2520 +1
==========================================
- Hits 33369 33368 -1
- Misses 5780 5786 +6
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, it works as expected.
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-973 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmytro-ndp we also need your approval before merging
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, ibuziuk, olexii4, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build 3.10 :: dashboard_3.10/13: Console, Changes, Git Data |
Build 3.11 :: dashboard_3.x/385: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.10/89: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5161: Console, Changes, Git Data |
PR has been verified successfully following "Steps to Reproduce" from https://issues.redhat.com/browse/CRW-4955 Good job, @olexii4 ! |
…ization (#973) * fix: workspace URL parameters after the user accepts OAuth authorization Signed-off-by: Oleksii Orel <oorel@redhat.com>
Build 3.11 :: push-latest-container-to-quay_3.x/3587: Console, Changes, Git Data |
…ization (#973) * fix: workspace URL parameters after the user accepts OAuth authorization Signed-off-by: Oleksii Orel <oorel@redhat.com>
Build 3.10 :: push-latest-container-to-quay_3.10/53: Console, Changes, Git Data |
Build 3.10 :: get-sources-rhpkg-container-build_3.10/88: dashboard : 3.10 :: Build 56747010 : quay.io/devspaces/dashboard-rhel8:3.10-47 |
Build 3.11 :: update-digests_3.x/4787: Console, Changes, Git Data |
Build 3.11 :: dashboard_3.x/385: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5161 triggered |
Build 3.10 :: update-digests_3.10/93: Console, Changes, Git Data |
Build 3.10 :: dashboard_3.10/13: Upstream sync done; /DS_CI/sync-to-downstream_3.10/89 triggered |
Build 3.11 :: operator-bundle_3.x/2250: Console, Changes, Git Data |
Build 3.10 :: operator-bundle_3.10/31: Console, Changes, Git Data |
…ization (#973) * fix: workspace URL parameters after the user accepts OAuth authorization Signed-off-by: Oleksii Orel <oorel@redhat.com>
Build 3.10 :: sync-to-downstream_3.10/90: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5162: Console, Changes, Git Data |
Build 3.10 :: push-latest-container-to-quay_3.10/54: Console, Changes, Git Data |
Build 3.10 :: sync-to-downstream_3.10/90: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.10/89 triggered; /job/DS_CI/job/dsc_3.10 triggered; |
Build 3.10 :: operator-bundle_3.10/31: Upstream sync done; /DS_CI/sync-to-downstream_3.10/90 triggered |
Build 3.10 :: copyIIBsToQuay/2077: Console, Changes, Git Data |
Build 3.11 :: push-latest-container-to-quay_3.x/3588: Console, Changes, Git Data |
Build 3.10 :: dsc_3.10/23: Console, Changes, Git Data |
Build 3.10 :: update-digests_3.10/93: Detected new images: rebuild operator-bundle |
Build 3.11 :: copyIIBsToQuay/2078: Console, Changes, Git Data |
Build 3.11 :: sync-to-downstream_3.x/5162: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5049 triggered; /job/DS_CI/job/dsc_3.x triggered; |
Build 3.11 :: operator-bundle_3.x/2250: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5162 triggered |
Build 3.11 :: dsc_3.x/1517: Console, Changes, Git Data |
Build 3.10 :: dsc_3.10/23: 3.10.0-CI |
Build 3.11 :: update-digests_3.x/4787: Detected new images: rebuild operator-bundle |
Build 3.11 :: dsc_3.x/1517: 3.11.0-CI |
What does this PR do?
Fix workspace URL parameters after the user accepts the OAuth authorization.
What issues does this PR fix or reference?
fixes https://issues.redhat.com/browse/CRW-4955
Is it tested? How?