Do not throw other then unauthorised error on token refresh #987
Conversation
vinokurig
requested review from
akurinnoy,
olexii4 and
ibuziuk
as code owners
|
Click here to review and test in web IDE: |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-987 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
+ Coverage 85.13% 85.17% +0.03%
==========================================
Files 380 380
Lines 39198 39198
Branches 2524 2521 -3
==========================================
+ Hits 33373 33388 +15
+ Misses 5798 5784 -14
+ Partials 27 26 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Verified on Che with |
| } | ||
| throw e; |
There was a problem hiding this comment.
@vinokurig would it be possible to add test for this functionality? Do we need to re-throw exception in general?
There was a problem hiding this comment.
would it be possible to add test for this functionality?
done
Do we need to re-throw exception in general?
Yes, the exception interrupts the workspace start event until the authorisation callback.
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-987 |
|
Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-987 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akurinnoy, artaleks9, ibuziuk, tolusha, vinokurig The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.11 :: dashboard_3.x/396: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5279: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3682: Console, Changes, Git Data |
|
Build 3.11 :: get-sources-rhpkg-container-build_3.x/5151: dashboard : 3.x :: Build 56976131 : quay.io/devspaces/dashboard-rhel8:3.11-23 |
|
Build 3.11 :: update-digests_3.x/4914: Console, Changes, Git Data |
|
Build 3.11 :: dashboard_3.x/396: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5279 triggered |
|
Build 3.11 :: operator-bundle_3.x/2287: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5280: Console, Changes, Git Data |
|
Build 3.11 :: push-latest-container-to-quay_3.x/3683: Console, Changes, Git Data |
|
Build 3.11 :: copyIIBsToQuay/2149: Console, Changes, Git Data |
|
Build 3.11 :: sync-to-downstream_3.x/5280: Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/5152 triggered; /job/DS_CI/job/dsc_3.x triggered; |
|
Build 3.11 :: operator-bundle_3.x/2287: Upstream sync done; /DS_CI/sync-to-downstream_3.x/5280 triggered |
|
Build 3.11 :: dsc_3.x/1554: Console, Changes, Git Data |
|
Build 3.11 :: update-digests_3.x/4914: Detected new images: rebuild operator-bundle |
Do not throw exceptions other then unauthorised exception on token refresh request when starting a workspace.
What does this PR do?
Do not throw exceptions other then unauthorised exception on token refresh request when starting a workspace.
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-5015
Is it tested? How?
See: workspace starts without any issues.
Release Notes
Docs PR