Allow overriding container images used in devfiles #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to override the registry url, organization, and tag of
images used in devfiles via environment variables
CHE_DEVFILE_IMAGE_REGISTRY_URL
CHE_DEVFILE_IMAGE_REGISTRY_ORGANIZATION
CHE_DEVFILE_IMAGE_REGISTRY_TAG
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
requested review from
l0rd,
nickboldt,
rhopp,
skabashnyuk and
vparfonov
as code owners
amisevsk
changed the title
davidfestal
requested changes
Oct 7, 2019
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
davidfestal
approved these changes
Oct 7, 2019
This was referenced Oct 7, 2019
nickboldt
reviewed
Oct 9, 2019
nickboldt
reviewed
Oct 9, 2019
nickboldt
requested changes
Oct 9, 2019
You just approved a commit that moves the start httpd logic into a CMD ;) |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
@nickboldt Updated PR, please take another look. |
nickboldt
reviewed
Oct 10, 2019
nickboldt
reviewed
Oct 10, 2019
nickboldt
approved these changes
Oct 10, 2019
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
* Add ability to override images used in devfiles at runtime
Adds the ability to override the registry url, organization, and tag of
images used in devfiles via environment variables
CHE_DEVFILE_IMAGE_REGISTRY_URL
CHE_DEVFILE_IMAGE_REGISTRY_ORGANIZATION
CHE_DEVFILE_IMAGE_REGISTRY_TAG
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
monaka
referenced
this pull request
in PizzaFactory/che-devfile-registry
Nov 25, 2019
* Add ability to override images used in devfiles at runtime
Adds the ability to override the registry url, organization, and tag of
images used in devfiles via environment variables
CHE_DEVFILE_IMAGE_REGISTRY_URL
CHE_DEVFILE_IMAGE_REGISTRY_ORGANIZATION
CHE_DEVFILE_IMAGE_REGISTRY_TAG
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow overriding image registry, organization, and tag in devfiles at runtime using the env vars
Also updates helm charts and OpenShift template.
What issues does this PR fix or reference?
eclipse-che/che#14693