Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset MAVEN_CONFIG env in Maven based images #160

Merged
merged 4 commits into from
Dec 13, 2019
Merged

Unset MAVEN_CONFIG env in Maven based images #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0498657
Patch maven base images to unset MAVEN_CONFIG env
svor Dec 9, 2019
c73b041
Set empty MAVEN_CONFIG in devfiles where samples use mvnw
svor Dec 11, 2019
030c53f
update all maven based images to unset MAVEN_CONFIG
svor Dec 11, 2019
e870e2e
code cleanup
svor Dec 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion devfiles/apache-camel-springboot/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ components:
image: quay.io/eclipse/che-java8-maven:nightly
env:
- name: MAVEN_CONFIG
value: "/home/user/.m2"
value: ""
- name: MAVEN_OPTS
value: "-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
-XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
Expand Down
2 changes: 1 addition & 1 deletion devfiles/java-maven/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ components:
image: quay.io/eclipse/che-java11-maven:nightly
env:
- name: MAVEN_CONFIG
value: /home/user/.m2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also unset MAVEN_CONFIG here, since the base image has MAVEN_CONFIG=/root/.m2 by default. Our sample project doesn't use mvnw but it might trip up someone trying to import their own project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unset for all maven based devfiles

value: ""
- name: MAVEN_OPTS
value: "-XX:MaxRAMPercentage=50 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
-XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
Expand Down
2 changes: 2 additions & 0 deletions devfiles/java-mongo/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ components:
alias: maven
image: quay.io/eclipse/che-java8-maven:nightly
env:
- name: MAVEN_CONFIG
value: ""
- name: JAVA_OPTS
value: "-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
-XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
Expand Down
2 changes: 2 additions & 0 deletions devfiles/java-mysql/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ components:
alias: tools
image: quay.io/eclipse/che-java8-maven:nightly
env:
- name: MAVEN_CONFIG
value: ""
- name: JAVA_OPTS
value: "-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
-XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
Expand Down
2 changes: 2 additions & 0 deletions devfiles/java-web-spring/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ components:
alias: tools
image: quay.io/eclipse/che-java8-maven:nightly
env:
- name: MAVEN_CONFIG
value: ""
- name: JAVA_OPTS
value: "-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
-XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
Expand Down
2 changes: 2 additions & 0 deletions devfiles/java-web-vertx/devfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ components:
alias: maven
image: quay.io/eclipse/che-java8-maven:nightly
env:
- name: MAVEN_CONFIG
value: ""
- name: JAVA_OPTS
value: "-XX:MaxRAMPercentage=50.0 -XX:+UseParallelGC -XX:MinHeapFreeRatio=10
-XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90
Expand Down