Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devfiles for PHP #21

Merged
merged 5 commits into from
Jun 27, 2019
Merged

Add devfiles for PHP #21

merged 5 commits into from
Jun 27, 2019

Conversation

svor
Copy link
Contributor

@svor svor commented Jun 26, 2019

What does this PR do?

Adds devfiles for PHP:

What issues does this PR fix or reference?

eclipse-che/che#13528
eclipse-che/che#13529

svor added 4 commits June 26, 2019 16:12
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
@svor svor requested review from l0rd and sleshchenko June 26, 2019 13:40
@svor svor self-assigned this Jun 26, 2019
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other seems good to me

devfiles/php-laravel/devfile.yaml Outdated Show resolved Hide resolved
devfiles/php-laravel/devfile.yaml Outdated Show resolved Hide resolved
devfiles/php-laravel/devfile.yaml Outdated Show resolved Hide resolved
Signed-off-by: Valeriy Svydenko <vsvydenk@redhat.com>
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svor svor merged commit 3f85a84 into eclipse-che:master Jun 27, 2019
@svor svor deleted the sv/php-stack branch June 27, 2019 14:46
monaka referenced this pull request in PizzaFactory/che-devfile-registry Jun 28, 2019
* Add devfiles for PHP; fix typo
monaka added a commit that referenced this pull request Feb 1, 2020
Ohrimenko1988 added a commit that referenced this pull request Jun 2, 2020
Signed-off-by: Ihor Okhrimenko <iokhrime@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants