fix: better recovery from a failed skopeo... #529
Conversation
… not resolved after 2 attempts, DON'T CHANGE the digest to a nullstring Change-Id: Ic65d99256542b646eb7f3e64f404f40071edab72 Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
requested review from
benoitf,
JPinkney,
svor,
tsmaeder,
vinokurig and
vitaliy-guliy
as code owners
|
Click here to review and test in web IDE: |
…close #526 Change-Id: I11a9933f515fcd7a9fafa3c62608b771d92e50ef Signed-off-by: nickboldt <nboldt@redhat.com>
|
Click here to review and test in web IDE: |
|
Replaces #526 |
|
Side note: can we get rid of node 10 and move to node 12 or 14? Or even node 16? https://catalog.redhat.com/software/containers/ubi8/nodejs-16/615aee9fc739c0a4123a87e1 Does the lang server we use in CRW (and presumably Che too) work with newer node, or is it tied to 10? We're on typescript lang server 0.3.7 - https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-plugin-java8/build/build_node10.sh#L19 We're on typescript 3.4.5: https://github.com/redhat-developer/codeready-workspaces-images/blob/crw-2-rhel-8/codeready-workspaces-plugin-java8/build/build_node10.sh#L18 |
|
If you approve this, please merge it. The question around node10/12/14/16 can be handled in a separate issue, should we agree it's time to update to the latest TS lang server. |
We can try to update node, for now I don't know any problems with it, but it needs to be tested with all samples which required node. |
|
@nickboldt I've created an issue for updating Node base image in CRW https://issues.redhat.com/browse/CRW-2527 |
* fix: output of meta.yaml should be yaml content Change-Id: Idcbe30c9f1c8ee1f0b0162a3061ee9210dd4d4cb Signed-off-by: Florent Benoit <fbenoit@redhat.com> * [release] Bump to 7.41.0-SNAPSHOT in main (#528) Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * chore(digests): update dockerfile base images Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * chore(sidecars): bump to new sidecar tags Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * fix: better recovery from a failed skopeo... (#529) * fix: better recovery from a failed skopeo inspect -- try again and if not resolved after 2 attempts, DON'T CHANGE the digest to a nullstring Change-Id: Ic65d99256542b646eb7f3e64f404f40071edab72 Signed-off-by: nickboldt <nboldt@redhat.com> * chore: include newer digest in this PR so we can simply merge this and close #526 Change-Id: I11a9933f515fcd7a9fafa3c62608b771d92e50ef Signed-off-by: nickboldt <nboldt@redhat.com> * [release] Bump to 7.40.0 in 7.40.x Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Florent Benoit <fbenoit@redhat.com> Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Nick Boldt <nboldt@redhat.com>
* fix: output of meta.yaml should be yaml content Change-Id: Idcbe30c9f1c8ee1f0b0162a3061ee9210dd4d4cb Signed-off-by: Florent Benoit <fbenoit@redhat.com> * [release] Bump to 7.41.0-SNAPSHOT in main (#528) Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * chore(digests): update dockerfile base images Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * chore(sidecars): bump to new sidecar tags Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> * fix: better recovery from a failed skopeo... (#529) * fix: better recovery from a failed skopeo inspect -- try again and if not resolved after 2 attempts, DON'T CHANGE the digest to a nullstring Change-Id: Ic65d99256542b646eb7f3e64f404f40071edab72 Signed-off-by: nickboldt <nboldt@redhat.com> * chore: include newer digest in this PR so we can simply merge this and close #526 Change-Id: I11a9933f515fcd7a9fafa3c62608b771d92e50ef Signed-off-by: nickboldt <nboldt@redhat.com> * fix: #20880 instead of a separate stage for dwtemplates, just use the node16 image as the builder, and then we don't have to repeat the same several steps in a new container... and don't have to fix perms in /devfiles/ folder either (#534) Change-Id: Ib61cfe1548e73ed2a8225596088250248b907c50 Signed-off-by: nickboldt <nboldt@redhat.com> * [release] Bump to 7.40.0 in 7.40.x Signed-off-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Florent Benoit <fbenoit@redhat.com> Co-authored-by: Mykhailo Kuznietsov <mkuznets@redhat.com> Co-authored-by: Nick Boldt <nboldt@redhat.com>
What does this PR do?
fix: better recovery from a failed skopeo inspect -- try again and if not resolved after 2 attempts, DON'T CHANGE the digest to a nullstring
Change-Id: Ic65d99256542b646eb7f3e64f404f40071edab72
Signed-off-by: nickboldt nboldt@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Avoids this problem:
https://github.com/eclipse-che/che-devfile-registry/pull/526/files#diff-d567d4dc0d879e5b1da3a21d592817871f3651f034a8d3c5d444a18a71ba243eR12
How to test this PR?
che-devfiles-registry/dockerfiles/antora-2.3/DockerfileARG BASE_IMAGE="docker.io/antora/antFFora:2.3.3"./build/workflows/check-sidecar-image-digests.shAfter 30 seconds, no change will be applied to the registry and the processing of other Dockerfiles will continue. \o/
To prove that it WILL change when it DOES find a different latest digest:
che-devfiles-registry/dockerfiles/antora-2.3/DockerfileFROM docker.io/antora/antora@sha256:f00barf./build/workflows/check-sidecar-image-digests.shWatch as the file is changed and your bad digest is reverted to a valid one. \o/
If you let the script run its course you should see ONE file changed:
dockerfiles/golang-1.17/Dockerfilehttps://github.com/eclipse-che/che-devfile-registry/pull/526/files#diff-8f51fac72ac1fc135355f5eaabe8e7984b6f79048c983e55dd78ca94d040677dR12
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.