-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bitbucket and Bitbucket Server support #752
Conversation
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
tools/devworkspace-generator/tests/bitbucket-server/bitbucket-server-resolver.spec.ts
Outdated
Show resolved
Hide resolved
tools/devworkspace-generator/tests/bitbucket/bitbucket-resolver.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general codebase looks good to me
@svor I have added some new fixes for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to run ./build.sh script and it was failed because of test didn't cover new code, could you please fix that.
The GH action didn't detect the problem because it builds only Dockerfile, probably we have to fix that but not in this PR
@svor I've fixed the tests so the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tested for both Bitbucket and Github repositories.
- Generated devworkspaces by:
node lib/entrypoint.js \
--devfile-url:https://bitbucket-bitbucket.apps.cluster-84ndn.84ndn.sandbox2846.opentlc.com/scm/myp/ansible-devspaces-demo.git \
--plugin-registry-url:https://che-plugin-registry-main.surge.sh/v3/ \
--editor-entry:che-incubator/che-code/latest \
--output-file:/tmp/devworkspace-che-code-ansible-latest.yaml
DevWorkspace che-code-ansible-demo was generated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Add Bitbucket and Bitbucket Server support
Screenshot/screencast of this PR
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-4323
How to test this PR?
yarn
See:
yaml
file is generated and contains the devfile from the repository.PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.