Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub authentication flow #1055

Merged
merged 3 commits into from
Jan 29, 2020
Merged

Update GitHub authentication flow #1055

merged 3 commits into from
Jan 29, 2020

Conversation

vinokurig
Copy link
Contributor

What does this PR do?

Updates according to new plugin that allows to authenticate the VsCode GitHub pull-request plugin in Che-theia.

What issues does this PR fix or reference?

eclipse-che/che-theia#604

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
Copy link

@rkratky rkratky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @vinokurig.

I added a couple of suggestions. Merge at will.

vinokurig and others added 2 commits January 29, 2020 09:26
…s-using-the-github-pr-plug-in.adoc

Co-Authored-By: Robert Krátký <rkratky@redhat.com>
…s-using-the-github-pr-plug-in.adoc

Co-Authored-By: Robert Krátký <rkratky@redhat.com>
@themr0c themr0c merged commit a351370 into master Jan 29, 2020
@vinokurig vinokurig deleted the che-14217 branch March 3, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants