Add section to configure labels #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tolusha
requested review from
yhontyk,
l0rd,
MichalMaler,
rkratky and
themr0c
as code owners
48 tasks
|
@themr0c |
themr0c
reviewed
Sep 28, 2020
modules/installation-guide/partials/proc_configuring-labels-for-routes-ingresses.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Sep 28, 2020
modules/installation-guide/partials/proc_configuring-labels-for-routes-ingresses.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Sep 28, 2020
modules/installation-guide/partials/proc_configuring-labels-for-routes-ingresses.adoc
Outdated
Show resolved
Hide resolved
themr0c
reviewed
Sep 28, 2020
|
|
||
| .Procedure | ||
|
|
||
| . To configure labels for routes update the Custom Resource with the following commands: |
There was a problem hiding this comment.
As far as I understood, Kubernetes <=> Ingresses and OpenShift <=> Routes. Is that right?
Then we should have 2 procedures to distinguish the 2 distinct scenarios:
- Configuring labels for OpenShift Routes using the CLI
- Configuring labels for Kubernetes Ingresses using the CLI
Additionally, it would be awesome to have one procedure describing the usage of the WebUI, probably like:
- Configuring labels for OpenShift Routes using the OpenShift Web Console
There was a problem hiding this comment.
Divided into 2 procedures.
There was a problem hiding this comment.
The procedure describing the usage of the WebUI make sense only for OpenShift and it will be much longer then using CLI.
I don't think it worth describing it.
themr0c
reviewed
Sep 28, 2020
modules/installation-guide/partials/proc_configuring-labels-for-routes-ingresses.adoc
Outdated
Show resolved
Hide resolved
|
@tolusha, Nice improvements! Very welcome! I added some comments. |
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
…r-routes-ingresses.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
…r-routes-ingresses.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
…r-routes-ingresses.adoc Co-authored-by: Fabrice Flore-Thébault <ffloreth@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
tolusha
force-pushed
the
configurelables
branch
from
0d54a63
to
fb5b2b9
Compare
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
@themr0c |
themr0c
approved these changes
Sep 30, 2020
themr0c
reviewed
Sep 30, 2020
modules/installation-guide/partials/proc_configuring-labels-for-routes.adoc
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anatolii Bazko abazko@redhat.com
What does this PR do?
Add section to configure labels
What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1034
PR Checklist
As the author of this Pull Request I made sure that:
valehas been run successfully against the PR branchShould be merged after eclipse-che/che-operator#449