Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure users can run more than one workspace #1628

Merged
merged 10 commits into from
Oct 19, 2020
Merged

Ensure users can run more than one workspace #1628

merged 10 commits into from
Oct 19, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Oct 8, 2020 •
edited
Loading

Signed-off-by: Anatolii Bazko abazko@redhat.com

Read our Contribution guide before submitting a PR.

What does this PR do?

Ensure users can run more than one workspace

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-1956

Specify the version of the product this PR applies to.

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@tolusha tolusha mentioned this pull request Oct 8, 2020
Closed
50 tasks
@tolusha
Copy link
Contributor Author

tolusha commented Oct 9, 2020

/cc
@themr0c

@themr0c
Copy link
Contributor

themr0c commented Oct 12, 2020

Now it looks like it should become a proper procedure file. Can you do that @tolusha?

@tolusha
Copy link
Contributor Author

tolusha commented Oct 12, 2020 •
edited
Loading

I am not sure if I understand you.
What do you mean?

@tolusha
Copy link
Contributor Author

tolusha commented Oct 13, 2020

@themr0c @MichalMaler
A new procedure added.

@MichalMaler
Copy link
Contributor

Hi Anatolii. Thank you for your contribution! Will take a look.

@MichalMaler MichalMaler self-assigned this Oct 14, 2020
@MichalMaler
Copy link
Contributor

Did a rebase from the fresh master branch. Doing review now.

@MichalMaler
Copy link
Contributor

My review is complete.

@MichalMaler
Copy link
Contributor

Vale errors:

  • may In the older commit => not relevant
  • can => Have absolutely no problem with it.

rkratky
rkratky suggested changes Oct 19, 2020
View reviewed changes
modules/administration-guide/partials/con_persistent-volume-configuration.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/con_persistent-volume-configuration.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_configuring-namespace-strategies.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_run-several-workspaces-at-a-time.adoc Outdated Show resolved Hide resolved
tolusha and others added 3 commits October 19, 2020 15:21
@tolusha @MichalMaler
Ensure users can run more than one workspace
0742a88 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha @l0rd @MichalMaler
Update modules/installation-guide/partials/proc_configuring-namespace…
ce5f32e 
…-strategies.adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
@tolusha @MichalMaler
Add procedure to run several workspaces at a time
86f1b62 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
MichalMaler and others added 6 commits October 19, 2020 15:21
@MichalMaler
Review
fcde61a 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler
fix
c7e79c7 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@tolusha @MichalMaler
Fix message
daf25b8 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@MichalMaler
fix2
581c15a 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler
fix3
8e110bd 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler
Apply suggestions from code review
ae95bb0 
Co-authored-by: Robert Krátký <rkratky@redhat.com>
@MichalMaler
renaming the file name
0e077e8 
Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler MichalMaler merged commit e74ac41 into master Oct 19, 2020
@MichalMaler MichalMaler deleted the RHDEVDOCS-1956 branch October 19, 2020 14:14
@MichalMaler MichalMaler added the need-cherry-pick/7.34.x need cherry-pick to 7.18.x branch label Oct 19, 2020
MichalMaler added a commit to MichalMaler/che-docs that referenced this pull request Oct 20, 2020
@tolusha @l0rd @MichalMaler
Ensure users can run more than one workspace (eclipse-che#1628)
2cd61dd 
* Ensure users can run more than one workspace

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/installation-guide/partials/proc_configuring-namespace-strategies.adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>

* Add procedure to run several workspaces at a time

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Fix message

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* fix2

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix3

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Apply suggestions from code review

Co-authored-by: Robert Krátký <rkratky@redhat.com>

* renaming the file name

Signed-off-by: Michal Maléř <mmaler@redhat.com>

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Michal Maléř <mmaler@redhat.com>
Co-authored-by: Michal Maléř <48474054+MichalMaler@users.noreply.github.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
MichalMaler added a commit that referenced this pull request Oct 20, 2020
@MichalMaler @tolusha @l0rd
Ensure users can run more than one workspace (#1628) (#1648)
47ca1a6 
* Ensure users can run more than one workspace

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/installation-guide/partials/proc_configuring-namespace-strategies.adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>

* Add procedure to run several workspaces at a time

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Fix message

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* fix2

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix3

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Apply suggestions from code review

Co-authored-by: Robert Krátký <rkratky@redhat.com>

* renaming the file name

Signed-off-by: Michal Maléř <mmaler@redhat.com>

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Michal Maléř <mmaler@redhat.com>
Co-authored-by: Michal Maléř <48474054+MichalMaler@users.noreply.github.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
@MichalMaler MichalMaler added cherry-picked to 7.30.x and removed need-cherry-pick/7.34.x need cherry-pick to 7.18.x branch labels Oct 20, 2020
MichalMaler added a commit to MichalMaler/che-docs that referenced this pull request Oct 20, 2020
@tolusha @l0rd @MichalMaler
Ensure users can run more than one workspace (eclipse-che#1628)
55f735d 
* Ensure users can run more than one workspace

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/installation-guide/partials/proc_configuring-namespace-strategies.adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>

* Add procedure to run several workspaces at a time

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Fix message

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* fix2

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix3

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Apply suggestions from code review

Co-authored-by: Robert Krátký <rkratky@redhat.com>

* renaming the file name

Signed-off-by: Michal Maléř <mmaler@redhat.com>

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Michal Maléř <mmaler@redhat.com>
Co-authored-by: Michal Maléř <48474054+MichalMaler@users.noreply.github.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
MichalMaler added a commit that referenced this pull request Oct 20, 2020
@MichalMaler @tolusha @l0rd
Ensure users can run more than one workspace (#1628) (#1650)
7e469ce 
* Ensure users can run more than one workspace

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/installation-guide/partials/proc_configuring-namespace-strategies.adoc

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>

* Add procedure to run several workspaces at a time

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Fix message

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* fix2

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix3

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* Apply suggestions from code review

Co-authored-by: Robert Krátký <rkratky@redhat.com>

* renaming the file name

Signed-off-by: Michal Maléř <mmaler@redhat.com>

Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Michal Maléř <mmaler@redhat.com>
Co-authored-by: Michal Maléř <48474054+MichalMaler@users.noreply.github.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>

Co-authored-by: Anatolii Bazko <abazko@redhat.com>
Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
Co-authored-by: Robert Krátký <rkratky@redhat.com>
@MichalMaler MichalMaler added the cherry-picked to 7.32.x cherry-picked to 7.32.x label Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalMaler MichalMaler MichalMaler approved these changes

@rkratky rkratky rkratky approved these changes

@yhontyk yhontyk Awaiting requested review from yhontyk

@themr0c themr0c Awaiting requested review from themr0c

@nickboldt nickboldt Awaiting requested review from nickboldt

@l0rd l0rd Awaiting requested review from l0rd

Assignees

@MichalMaler MichalMaler

Labels
cherry-picked to 7.32.x cherry-picked to 7.32.x kind/enhancement
Projects
None yet
Milestone
No milestone
7 participants
@tolusha @themr0c @MichalMaler @nickboldt @l0rd @rkratky @che-bot