Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions to install ingress-nginx #1686

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

aledbf
Copy link
Contributor

@aledbf aledbf commented Nov 4, 2020

Read our Contribution guide before submitting a PR.

What does this PR do?

Update inststructions

What issues does this PR fix or reference?

An old version of ingress-nginx and syncs intructions

Specify the version of the product this PR applies to.

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

Signed-off-by: Manuel Alejandro de Brito Fontes <aledbf@gmail.com>
@yhontyk yhontyk merged commit e9013bd into eclipse-che:master Nov 4, 2020
@l0rd
Copy link
Contributor

l0rd commented Nov 6, 2020

Thank you @aledbf for your contribution. I couldn't help but notice that you are the creator and maintainer of the ngninx ingress controller and I would love to get your opinion on a couple of issues we recently had:

  1. We have tried to use the default TLS certificate of the ngninx ingress on minikube but it is considered invalid by browsers and hence it's mostly useless. Is that right? Is it a problem that you may consider to fix?
  2. To update the default TLS certificate used by the nginx controller on minikube (after enabling the ingress addon) I create a secret and patch the nginx-ingress-controller deployment in the kube-system namespace. Isn't there a way to avoid patching the deployment and configure the default TLS cert before the controller is started?

Those are mostly minikube questions but hopefully you can share some thoughts.

@aledbf
Copy link
Contributor Author

aledbf commented Nov 6, 2020

Thank you @aledbf for your contribution. I couldn't help but notice that you are the creator and maintainer of the ngninx ingress controller and I would love to get your opinion on a couple of issues we recently had:

  1. We have tried to use the default TLS certificate of the ngninx ingress on minikube but it is considered invalid by browsers and hence it's mostly useless. Is that right?

You can change that using the flag --default-ssl-certificate to point to a secret containing an SSL certificate to be used by the default HTTPS server https://kubernetes.github.io/ingress-nginx/user-guide/cli-arguments/

Is it a problem that you may consider to fix?

Not sure this is a problem. We need to expose one SSL certificate. If none is specified we need to create one in order to be able to serve HTTPS connections (without one we can only close the connection).

  1. To update the default TLS certificate used by the nginx controller on minikube (after enabling the ingress addon) I create a secret and patch the nginx-ingress-controller deployment in the kube-system namespace. Isn't there a way to avoid patching the deployment and configure the default TLS cert before the controller is started?

That is one way to do it. You can also use a static manifest with the required changes like we do for kind and publish a link https://kind.sigs.k8s.io/docs/user/ingress/#ingress-nginx

@l0rd
Copy link
Contributor

l0rd commented Nov 6, 2020

@aledbf got it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants