Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update import additional CA certificates chapter #1719

Merged
merged 4 commits into from
Dec 15, 2020
Merged

Update import additional CA certificates chapter #1719

merged 4 commits into from
Dec 15, 2020

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Dec 4, 2020 •
edited by tolusha
Loading

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this PR do?

Updated documentation on how to add custom TLS CA certificates into Che installation.

What issues does this PR fix or reference?

eclipse-che/che#17634
eclipse-che/che#18339
eclipse-che/che#18018

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@mmorhun mmorhun self-assigned this Dec 4, 2020
@tolusha tolusha mentioned this pull request Dec 4, 2020
Closed
58 tasks
@tolusha tolusha mentioned this pull request Dec 7, 2020
Closed
56 tasks
@mmorhun
Update import additional CA certificates chapter
4a648ca 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun
Add reference between pages
c79c3a8 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@mmorhun
Copy link
Contributor Author

mmorhun commented Dec 14, 2020

@l0rd @davidfestal could you take a look?

@mmorhun mmorhun marked this pull request as ready for review December 14, 2020 14:49
@mmorhun mmorhun requested a review from a team as a code owner December 14, 2020 14:49
@mmorhun
Fixes
c19b888 
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@tolusha
Copy link
Contributor

tolusha commented Dec 15, 2020

@themr0c @boczkowska
It is ready to review

@yhontyk yhontyk self-assigned this Dec 15, 2020
yhontyk
yhontyk approved these changes Dec 15, 2020
View reviewed changes
Copy link

@yhontyk yhontyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion regarding AsciiDoc formatting, everything else LGTM.

modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
modules/installation-guide/partials/proc_importing-untrusted-tls-certificates-old.adoc Outdated Show resolved Hide resolved
@mmorhun
Apply suggestions from code review
808788f 
Co-authored-by: Yana Hontyk <yhontyk@redhat.com>
@mmorhun mmorhun merged commit b309a50 into master Dec 15, 2020
@mmorhun mmorhun deleted the che-17634 branch December 15, 2020 15:35
@tolusha tolusha mentioned this pull request Dec 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolusha tolusha tolusha approved these changes

@yhontyk yhontyk yhontyk approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@davidfestal davidfestal Awaiting requested review from davidfestal

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@rkratky rkratky Awaiting requested review from rkratky

@themr0c themr0c Awaiting requested review from themr0c

Assignees

@mmorhun mmorhun

@yhontyk yhontyk

Labels
kind/bug
Projects
None yet
Milestone
No milestone
4 participants
@mmorhun @tolusha @yhontyk @che-bot