Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obtain and persist Bitbucket personal access token as k8s secret #1807

Merged
merged 23 commits into from
Feb 11, 2021
Merged

Obtain and persist Bitbucket personal access token as k8s secret #1807

merged 23 commits into from
Feb 11, 2021

Conversation

skabashnyuk
Copy link
Contributor

@skabashnyuk skabashnyuk commented Jan 22, 2021 •
edited
Loading

Read our Contribution guide before submitting a PR.

What does this PR do?

Documentation for the feature "Obtain and persist Bitbucket personal access token as k8s secret"
Also include https://issues.redhat.com/browse/RHDEVDOCS-2469

What issues does this PR fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-2469
eclipse-che/che#18726

Specify the version of the product this PR applies to.

7.27

PR Checklist

As the author of this Pull Request I made sure that:

  • vale has been run successfully against the PR branch
  • Link checker has been run successfully against the PR branch
  • Documentation describes a scenario that is already covered by QE tests, otherwise an issue has been created and acknowledged by Che QE team
  • Changed article references are updated where they are used (or a redirect has been set up on the docs side):

@skabashnyuk
Copy link
Contributor Author

At this moment Navbar looks like this
Знімок екрана 2021-01-22 о 14 14 41

@skabashnyuk skabashnyuk changed the title Obtain and persist Bitbucket personal access token as k8s secret [WIP] Obtain and persist Bitbucket personal access token as k8s secret Jan 22, 2021
@themr0c
Copy link
Contributor

themr0c commented Jan 22, 2021

Nice! Can you also merge Managing users into Manage identities and authorizations?

@skabashnyuk
Copy link
Contributor Author

Nice! Can you also merge Managing users into Manage identities and authorizations?

ok

@skabashnyuk
Copy link
Contributor Author

Latest changes include

  • merge Managing users into Manage identities and authorizations
  • Moving Authentication on Bitbucket servers to user guide

Знімок екрана 2021-01-25 о 17 58 30
Знімок екрана 2021-01-25 о 17 58 01

@skabashnyuk
Copy link
Contributor Author

At this point, I'm working on this part.
Знімок екрана 2021-01-27 о 09 54 39

@skabashnyuk skabashnyuk mentioned this pull request Feb 2, 2021
Merged
9 tasks
@skabashnyuk
Fixed configuring-openshift-oauth link
9d4c24a
@skabashnyuk
fixup! Fixed configuring-openshift-oauth link
8039170 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
fixup! fixup! Fixed configuring-openshift-oauth link
3dd3771 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk skabashnyuk marked this pull request as ready for review February 2, 2021 11:57
@skabashnyuk skabashnyuk changed the title [WIP] Obtain and persist Bitbucket personal access token as k8s secret Obtain and persist Bitbucket personal access token as k8s secret Feb 2, 2021
@themr0c themr0c self-assigned this Feb 3, 2021
@skabashnyuk skabashnyuk changed the title Obtain and persist Bitbucket personal access token as k8s secret Obtain and persist Bitbucket personal access token as k8s secret [Do not merge before https://github.com/eclipse/che/pull/18726] Feb 3, 2021
mshaposhnik
mshaposhnik approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@mshaposhnik mshaposhnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

modules/administration-guide/partials/proc_configuring-bitbucket-server-oauth1.adoc Outdated Show resolved Hide resolved
modules/administration-guide/partials/proc_configuring-bitbucket-server-oauth1.adoc Outdated Show resolved Hide resolved
@themr0c
Copy link
Contributor

themr0c commented Feb 3, 2021 •
edited
Loading

What is supported exactly? Both Bitbucket Cloud and Bitbucket Data Center? See:https://www.atlassian.com/software/bitbucket/pricing

Answer is: "Bitbucket Server" only.

@themr0c themr0c added this to the 7.27.x milestone Feb 4, 2021
@themr0c
Copy link
Contributor

themr0c commented Feb 5, 2021

More TW suggestions in: skabashnyuk#2

themr0c
themr0c approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@themr0c themr0c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for a second TW review.

@skabashnyuk skabashnyuk changed the title Obtain and persist Bitbucket personal access token as k8s secret [Do not merge before https://github.com/eclipse/che/pull/18726] Obtain and persist Bitbucket personal access token as k8s secret Feb 10, 2021
@skabashnyuk skabashnyuk merged commit 5f3b9e4 into eclipse-che:master Feb 11, 2021
@skabashnyuk skabashnyuk deleted the che18388 branch February 11, 2021 14:26
@themr0c themr0c modified the milestones: 7.27.x, 7.26.x Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themr0c themr0c themr0c approved these changes

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@yhontyk yhontyk yhontyk approved these changes

@MichalMaler MichalMaler Awaiting requested review from MichalMaler

@rkratky rkratky Awaiting requested review from rkratky

Assignees

@themr0c themr0c

Labels
kind/task
Projects
None yet
Milestone
7.26.x
6 participants
@skabashnyuk @themr0c @mshaposhnik @sleshchenko @yhontyk @che-bot