Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update restore docs to include new rollback feature #2124

Merged
merged 15 commits into from
Oct 21, 2021
Merged

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Sep 30, 2021

Signed-off-by: Mykola Morhun mmorhun@redhat.com

What does this pull request change?

Updates backup / restore documentation in accordance with new features implemented

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/CRW-1497

Specify the version of the product this pull request applies to

  • 7.38.0

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@mmorhun mmorhun self-assigned this Sep 30, 2021
@mmorhun mmorhun requested a review from a team as a code owner September 30, 2021 14:11
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Click here to review and test in web IDE: Contribute

Comment on lines 24 to 29
{prod} Operator creates a new backup on every {prod-short} update.
Depending on the xref:define-backup-server-for-operator.adoc[configuration], backups before {prod-short} update are stored in:

* The only configured backup server
* Backup server which configuration marked with `che.eclipse.org/backup-before-update: true` annotation if there is more than one configuration
* Internal backup server if no backup servers configured or configured several and `che.eclipse.org/backup-before-update: true` annotation missing

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List means that backup is stored in an every item, but we have to mention a default configuration and how to change it.

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

Click here to review and test in web IDE: Contribute

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 4, 2021

Click here to review and test in web IDE: Contribute

@mmorhun
Copy link
Contributor Author

mmorhun commented Oct 6, 2021

@themr0c @MichalMaler @rkratky please review someone.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Click here to review and test in web IDE: Contribute

@MichalMaler MichalMaler added this to the 7.37.x milestone Oct 7, 2021
@MichalMaler MichalMaler added this to In progress in Reviews via automation Oct 7, 2021
@MichalMaler MichalMaler self-assigned this Oct 7, 2021
@mmorhun
Copy link
Contributor Author

mmorhun commented Oct 7, 2021

I think we should wait for or merge into #2121

@MichalMaler MichalMaler mentioned this pull request Oct 11, 2021
6 tasks
@MichalMaler
Copy link
Contributor

MichalMaler commented Oct 11, 2021

My review this PR by @mmorhun is here.
https://docs.google.com/document/d/1J4PH7CRjWu_bSmzfP-Up09_eJ_XR3CQzXya00dm4SGc/edit

I have also a PR review, but i wanted to synchronize all names (of files, IDs, and headings) and I am not done yet.
https://github.com/eclipse/che-docs/pull/2133/files

It is possible it will colide with what @max-cx is doing in his own PR.

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

* MMaler-brief-review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* vale

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@MichalMaler MichalMaler added need-cherry-pick/7.36.x base for CRW 2.12 and removed need-cherry-pick/7.36.x base for CRW 2.12 labels Oct 21, 2021
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

* review

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* sync

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* xref fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* renaming

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* renaming

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fixes

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* xref

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* html test failures fix

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* fixes

Signed-off-by: Michal Maléř <mmaler@redhat.com>

* vale

Signed-off-by: Michal Maléř <mmaler@redhat.com>
@MichalMaler MichalMaler marked this pull request as ready for review October 21, 2021 13:46
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Reviews automation moved this from In progress to Reviewer approved Oct 21, 2021
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

1 similar comment
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@MichalMaler MichalMaler merged commit 3c76f57 into master Oct 21, 2021
@MichalMaler MichalMaler deleted the crw-1497 branch October 21, 2021 14:57
Reviews automation moved this from Reviewer approved to Done Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
5 participants