Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarification for maven users #2328

Merged
merged 4 commits into from
May 19, 2022
Merged

fix: clarification for maven users #2328

merged 4 commits into from
May 19, 2022

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented May 18, 2022

What does this pull request change

This PR adds a note about the possibility of specifying a custom path of the settings.xml file for Maven users to improve UX.

What issues does this pull request fix or reference

RHDEVDOCS-2595

Specify the version of the product this pull request applies to

Pull request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@max-cx max-cx requested review from rkratky, themr0c and a team as code owners May 18, 2022 12:56
@max-cx max-cx requested review from amisevsk and removed request for a team May 18, 2022 12:56
@che-bot che-bot added this to Triage in Reviews May 18, 2022
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-cx nitpick comment. Otherwise LGTM

modules/end-user-guide/pages/mounting-secrets.adoc Outdated Show resolved Hide resolved
Reviews automation moved this from Triage to In progress May 18, 2022
Co-authored-by: Srivaralakshmi Ramani <srr@redhat.com>
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@max-cx Approved!

@Srivaralakshmi
Copy link
Contributor

/lgtm

Copy link
Contributor

@RickJWagner RickJWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

max-cx and others added 2 commits May 18, 2022 17:49
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
Co-authored-by: Rolfe Dlugy-Hegwer <rolfedh@users.noreply.github.com>
@themr0c themr0c added this to the 7.46 milestone May 19, 2022
@themr0c themr0c merged commit 3c0a13b into eclipse-che:master May 19, 2022
Reviews automation moved this from In progress to Done May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Reviews
  
Done
6 participants