Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pem 'trusted certificate' update #2388

Merged
merged 8 commits into from
Jul 20, 2022
Merged

fix: pem 'trusted certificate' update #2388

merged 8 commits into from
Jul 20, 2022

Conversation

deerskindoll
Copy link
Contributor

What does this pull request change?

Update of the "Importing untrusted TLS certificates to Che doc"

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-3370

Specify the version of the product this pull request applies to

3.1

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@deerskindoll deerskindoll requested review from rkratky, themr0c and a team as code owners July 4, 2022 12:48
@deerskindoll deerskindoll requested a review from svor July 4, 2022 12:48
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

🎊 Navigate the preview: https://62d7ea93d788633f8b286239--eclipse-che-docs-pr.netlify.app 🎊

@che-bot che-bot added this to Triage in Reviews Jul 4, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jul 4, 2022

Click here to review and test in web IDE: Contribute

Reviews automation moved this from Triage to In progress Jul 5, 2022
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deerskindoll Left some suggestions. PTAL. Thanks!

deerskindoll and others added 2 commits July 7, 2022 15:18
…tificates.adoc

Co-authored-by: Srivaralakshmi Ramani <srr@redhat.com>
@deerskindoll deerskindoll changed the title fix: pem 'trusted certificate' update WIP fix: pem 'trusted certificate' update Jul 8, 2022
@deerskindoll deerskindoll changed the title WIP fix: pem 'trusted certificate' update fix: pem 'trusted certificate' update Jul 8, 2022
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deerskindoll PTAL at the suggestions. Thanks!

…tificates.adoc

Co-authored-by: Srivaralakshmi Ramani <srr@redhat.com>
Copy link
Contributor

@Srivaralakshmi Srivaralakshmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deerskindoll Thanks for the changes. Approved!

@Srivaralakshmi
Copy link
Contributor

/lgtm

Reviews automation moved this from In progress to Approved Jul 20, 2022
@rkratky rkratky merged commit 44fbf93 into eclipse-che:main Jul 20, 2022
Reviews automation moved this from Approved to Done Jul 20, 2022
@che-bot che-bot added this to the 7.50 milestone Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
6 participants