Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Antora in charge of single-sourcing and validating content, generating and validating the website #2455

Merged
merged 1 commit into from
Sep 27, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Sep 22, 2022

Previously, we were piling up scripts in gulp and build.sh.

With this pull request, Antora is in charge:

  1. Antora generates docs and images we are single-sourcing from external sources
  2. Antora validates the content
  3. Antora builds the website
  4. Antora validates the built website.

Gulp has a more narrowed scope:

  1. Gulp delegates the build task to Antora
  2. Gulp starts the web server
  3. Gulp watches the content for changes to launch a rebuild.

In details:

The Antora Collector extension single-sources external content into an uncommitted place (build/collector subdirectories), and register the content to Antora:

  • Generate CheCluster reference ./tools/checluster_docs_gen.sh
  • Generate Che server properties reference ./tools/environment_docs_gen.sh
  • Generate diagrams ./tools/create_architecture_diagrams.py (New! It was not automated)
  • Detect unused content ./tools/detect-unused-content.sh
  • Vale ./tools/validate_language_changes.sh

Local Antora extensions validate the content:

  • Validate conversion to plain AsciiDoc (for downstream) extensions/antora-to-plain-asciidoc.js
  • Validate external links extensions/htmltest.js in the output

This pull request also:

  • Removes generated content from the committed files.
  • Removed obsolete calls in gulp.js and build.sh
  • Refactor all scripts for a more consistent, less verbose, colorized output
  • Update product version for stable version (7.53)
  • Fix build errors and warnings

Additional resources:

A successful run example:

Screenshot from 2022-09-27 10-19-18

An error example:

Screenshot from 2022-09-27 10-15-47

@themr0c themr0c requested review from rkratky, max-cx and a team as code owners September 22, 2022 14:01
@themr0c themr0c requested a review from svor September 22, 2022 14:01
@che-bot che-bot added this to Triage in Reviews Sep 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 22, 2022

🎊 Navigate the preview: https://6333ef5278cc094f86586c5d--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

antora.yml Outdated Show resolved Hide resolved
@themr0c themr0c changed the title chore: Antora Collector extension chore: use Antora Collector extension and local Antora extensions rather than gulp where possible Sep 26, 2022
…ension rather than gulp (and build.sh).

chore: Validating content by using local Antora extensions rather than gulp (and build.sh).
chore: Consistent output
fix: fix build errors and warnings
See: https://gitlab.com/antora/antora-collector-extension
@themr0c themr0c changed the title chore: use Antora Collector extension and local Antora extensions rather than gulp where possible chore: Antora in charge of single-sourcing and validating content, generating and validating the website Sep 27, 2022
Reviews automation moved this from Triage to Approved Sep 27, 2022
@themr0c themr0c merged commit 7360344 into eclipse-che:main Sep 27, 2022
@themr0c themr0c deleted the chore-collector branch September 27, 2022 14:50
Reviews automation moved this from Approved to Done Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
3 participants