Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing _{context} from ids #2474

Merged
merged 2 commits into from
Oct 21, 2022
Merged

chore: removing _{context} from ids #2474

merged 2 commits into from
Oct 21, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Oct 19, 2022

  • It is useless upstream.
  • It is breaking xref statements in downstream.

What does this pull request change?

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@themr0c themr0c requested review from rkratky, max-cx and a team as code owners October 19, 2022 08:01
@themr0c themr0c requested a review from amisevsk October 19, 2022 08:01
@themr0c themr0c added this to the 7.56 milestone Oct 19, 2022
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@che-bot che-bot added this to Triage in Reviews Oct 19, 2022
@github-actions
Copy link

github-actions bot commented Oct 19, 2022

🎊 Navigate the preview: https://635254356e3e461099791859--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Reviews automation moved this from Triage to Approved Oct 19, 2022
* It is useless upstream.
* It is breaking xref statements in downstream.
@themr0c
Copy link
Contributor Author

themr0c commented Oct 21, 2022

Confirmed during CCS best practice meeting that the context attribute in the module id is required only when the docs are using nested assemblies.

@themr0c themr0c merged commit 201525f into eclipse-che:main Oct 21, 2022
Reviews automation moved this from Approved to Done Oct 21, 2022
@themr0c themr0c deleted the chore-remove-context-in-id branch October 21, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
3 participants