Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: version 7.56.0 in main branch #2479

Merged
merged 1 commit into from
Nov 7, 2022
Merged

chore: version 7.56.0 in main branch #2479

merged 1 commit into from
Nov 7, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Nov 7, 2022

What does this pull request change?

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@themr0c themr0c added this to the 7.56 milestone Nov 7, 2022
@themr0c themr0c requested review from rkratky, max-cx and a team as code owners November 7, 2022 10:06
@themr0c themr0c requested a review from ibuziuk November 7, 2022 10:06
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Click here to review and test in web IDE: Contribute

@che-bot che-bot added this to Triage in Reviews Nov 7, 2022
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎊 Navigate the preview: https://6368d9ec991d2300b2cd41d9--eclipse-che-docs-pr.netlify.app 🎊

@max-cx
Copy link
Contributor

max-cx commented Nov 7, 2022

@themr0c, I wonder if we also need to check and update the following variables:

prod-stable-channel-starting-csv: eclipse-che.v7.49.0
prod-operator-index: registry.access.redhat.com/redhat/community-operator-index:v4.10
ocp4-ver: "4.10"
devworkspace-operator-version-patch: "0.15.2"
devworkspace-operator-index: registry.redhat.io/redhat/redhat-operator-index:v4.10

If yes on any of them, then I have two suggestions:

  1. Group into one separate section of this file all the variables that we need to double-check each time we update the release number
  2. Add a comment with the link to the page where we can quickly check the latest value of each of those variables.

Copy link
Contributor

@max-cx max-cx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please first read my comment #2479 (comment).

Reviews automation moved this from Triage to Approved Nov 7, 2022
@themr0c themr0c merged commit b5b49a9 into eclipse-che:main Nov 7, 2022
Reviews automation moved this from Approved to Done Nov 7, 2022
@themr0c themr0c deleted the pr-7.56 branch November 7, 2022 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
3 participants