chore: #21804 update che server config to use .spec.properties.server.properties for cheLogLevel and customCheProperties.CHE_LOGS_APPENDERS_IMPL, as CHE_WORKSPACE_DEFAULT__MEMORY__LIMIT__MB is obsolete #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
requested review from
rkratky,
themr0c,
max-cx and
a team
as code owners
|
Click here to review and test in web IDE: |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: https://6373db9f143ca0008d591c9b--eclipse-che-docs-pr.netlify.app 🎊 |
nickboldt
changed the title
|
hmm. so that didn't work... I was able to change to and get less console logging in the devspaces (che-server) pod to my CheCluster yaml ... kept being removed by the editor. So... not sure how to apply this env var. |
tolusha
reviewed
Nov 15, 2022
| extraProperties: | ||
| pass:[CHE_WORKSPACE_DEFAULT__MEMORY__LIMIT__MB]: "2048" | ||
| logLevel: INFO | ||
| customCheProperties: |
There was a problem hiding this comment.
I dont know why we need these changes since there is no customCheProperties anymore.
It is all about extraProperties
There was a problem hiding this comment.
spec:
components:
cheServer:
extraProperties:
CHE_LOGS_APPENDERS_IMPL: json
This is the correct setup, basically, the docs should say that this way one can add any env var to the che server pod
There was a problem hiding this comment.
ok, changed. thanks! I assume that's the correct yaml ?
….properties for cheLogLevel and customCheProperties.CHE_LOGS_APPENDERS_IMPL, as CHE_WORKSPACE_DEFAULT__MEMORY__LIMIT__MB is obsolete Signed-off-by: Nick Boldt <nboldt@redhat.com> update sample - still need to verify this works Signed-off-by: Nick Boldt <nboldt@redhat.com> Update con_understanding-che-server-advanced-configuration.adoc
nickboldt
force-pushed
the
21804_better_example_customCheProperties_and_cheLogLevel
branch
from
cc52dce
to
aa9e053
Compare
tolusha
reviewed
Nov 16, 2022
| spec: | ||
| components: | ||
| cheServer: | ||
| extraProperties: | ||
| pass:[CHE_WORKSPACE_DEFAULT__MEMORY__LIMIT__MB]: "2048" | ||
| CHE_LOGS_APPENDERS_IMPL: json | ||
| ---- |
tolusha
approved these changes
Nov 16, 2022
themr0c
approved these changes
Nov 16, 2022
themr0c
deleted the
21804_better_example_customCheProperties_and_cheLogLevel
branch
themr0c
pushed a commit
that referenced
this pull request
Nov 16, 2022
….properties for cheLogLevel and customCheProperties.CHE_LOGS_APPENDERS_IMPL, as CHE_WORKSPACE_DEFAULT__MEMORY__LIMIT__MB is obsolete (#2494)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: #21804 update che server config to use .spec.properties.server.properties for cheLogLevel and customCheProperties.CHE_LOGS_APPENDERS_IMPL, as CHE_WORKSPACE_DEFAULT__MEMORY__LIMIT__MB is obsolete
Signed-off-by: Nick Boldt nboldt@redhat.com
fixes eclipse-che/che#21804
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#21804
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.