fix: Replace Eclipse Theia in examples #2495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here to review and test in web IDE: |
|
🎊 Navigate the preview: https://638f617382a7c600829f28f5--eclipse-che-docs-pr.netlify.app 🎊 |
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
Seems ok but it would be easier to downstream this if you use a che-code example, as that's the new default (not idea) in both Che and DS. Also since you are using che-code on line 10 already... https://github.com/eclipse-che/che-docs/pull/2495/files#diff-54d179fd6ca1bbc0d938388bb0adbac6a9ced7bb9d4e23d368654269f815e6c3R10 ... this would make the full example more internally consistent. |
themr0c
reviewed
Nov 22, 2022
themr0c
reviewed
Nov 23, 2022
themr0c
approved these changes
Nov 28, 2022
nickboldt
reviewed
Nov 28, 2022
modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc
Outdated
Show resolved
Hide resolved
nickboldt
reviewed
Nov 28, 2022
modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc
Outdated
Show resolved
Hide resolved
nickboldt
reviewed
Nov 28, 2022
nickboldt
requested changes
Nov 28, 2022
…yaml.adoc Co-authored-by: Max Leonov <mleonov@redhat.com>
nickboldt
reviewed
Dec 5, 2022
modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc
Outdated
Show resolved
Hide resolved
nickboldt
approved these changes
Dec 5, 2022
…yaml.adoc Co-authored-by: Nick Boldt <nboldt@redhat.com>
max-cx
commented
Dec 6, 2022
modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc
Outdated
Show resolved
Hide resolved
max-cx
added a commit
that referenced
this pull request
Dec 6, 2022
* replace the yaml block conctent in the inline example * replace Theia in Example 5 * replace che-code with che-idea in oexample 1 * rename name of container in example 5 * Update modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc Co-authored-by: Max Leonov <mleonov@redhat.com> * Update modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc Co-authored-by: Nick Boldt <nboldt@redhat.com> * Update modules/end-user-guide/partials/ref_parameters-for-che-editor-yaml.adoc Co-authored-by: Nick Boldt <nboldt@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
This PR updates the page https://www.eclipse.org/che/docs/stable/end-user-guide/selecting-an-in-browser-ide-for-all-workspaces-that-clone-the-same-git-repository/#parameters-for-che-editor-yaml, where Eclipse Theia is replaced by another editor.
What issues does this pull request fix or reference?
https://issues.redhat.com/browse/RHDEVDOCS-4578
Specify the version of the product this pull request applies to
mainand7.56.xPull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.