Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation section "Calculating Che resource requirements" with CPU and VS Code based workspaces details #2499

Merged
merged 6 commits into from Nov 22, 2022
Merged

Updating documentation section "Calculating Che resource requirements" with CPU and VS Code based workspaces details #2499

merged 6 commits into from Nov 22, 2022

Conversation

themr0c
Copy link
Contributor

@themr0c themr0c commented Nov 21, 2022

Use Visual Studio Code in the example in Calculating Che resource requirements > Workspaces requirements

This pull requests contains also updates to clarify the tables, based on the observation of a recent deployment.

What does this pull request change?

Firefox_Screenshot_2022-11-21T15-11-42 345Z

What issues does this pull request fix or reference?

fixes: https://issues.redhat.com/browse/RHDEVDOCS-4562

Specify the version of the product this pull request applies to

Che 7.56

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@themr0c themr0c requested review from rkratky, max-cx and a team as code owners November 21, 2022 12:12
@themr0c themr0c added this to the 7.56 milestone Nov 21, 2022
@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@che-bot che-bot added this to Triage in Reviews Nov 21, 2022
@github-actions
Copy link

github-actions bot commented Nov 21, 2022

🎊 Navigate the preview: https://637b951a1f7d1243c6d041b8--eclipse-che-docs-pr.netlify.app 🎊

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Reviews automation moved this from Triage to Approved Nov 21, 2022
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some minor suggestions, check them out.

themr0c and others added 2 commits November 21, 2022 15:00
…quirements.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@themr0c themr0c requested a review from l0rd November 21, 2022 16:07
@themr0c themr0c merged commit ffa5f69 into eclipse-che:main Nov 22, 2022
Reviews automation moved this from Approved to Done Nov 22, 2022
@themr0c themr0c deleted the rhdevdocs-4562-workspace-requirements branch November 22, 2022 08:23
themr0c added a commit that referenced this pull request Nov 22, 2022
…ts (#2499)

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@l0rd l0rd added the status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording label Nov 24, 2022
@l0rd l0rd changed the title docs: Use Visual Studio Code in the example in Calculating requirements Updating documentation section "Calculating Che resource requirements" with CPU and VS Code based workspaces details Nov 24, 2022
@deerskindoll
Copy link
Contributor

Sync'd to Red Hat JIRA https://issues.redhat.com/browse/CRW-3621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported to 7.56.x new&noteworthy status/release-notes-review-needed Issues that needs to be reviewed by the doc team for the Release Notes wording target/branch
Projects
Reviews
  
Done
5 participants