-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify KIP doc #2711
Merged
Simplify KIP doc #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
🎊 Navigate the preview: https://66158e14858a451e5fb806ae--eclipse-che-docs-pr.netlify.app 🎊 |
deerskindoll
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny edits
modules/administration-guide/pages/installing-image-puller-by-using-cli.adoc
Outdated
Show resolved
Hide resolved
modules/administration-guide/pages/installing-image-puller-by-using-cli.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
deerskindoll
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fixes the nav menu issue
otherwise, lgtm
modules/administration-guide/pages/configuring-image-puller-to-pre-pull-custom-images.adoc
Outdated
Show resolved
Hide resolved
…-pre-pull-custom-images.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
deerskindoll
added a commit
that referenced
this pull request
Apr 15, 2024
* Simplify KIP doc Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Add pages about configuring image-puller Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Fixes Signed-off-by: Anatolii Bazko <abazko@redhat.com> * Update modules/administration-guide/pages/configuring-image-puller-to-pre-pull-custom-images.adoc Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com> --------- Signed-off-by: Anatolii Bazko <abazko@redhat.com> Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
What issues does this pull request fix or reference?
https://issues.redhat.com/browse/CRW-5723
Specify the version of the product this pull request applies to
main
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modified
step reports no vale warnings.