Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify KIP doc #2711

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Simplify KIP doc #2711

merged 4 commits into from
Apr 9, 2024

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Apr 4, 2024

What does this pull request change?

  • Add articles how to deploy KIP operator on cluster
  • Add articles how to configure KIP
  • Remove duplicated info

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/CRW-5723

Specify the version of the product this pull request applies to

main

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
    • The page contains a redirection for the previous URL.
    • Propagate the URL change in:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha requested review from deerskindoll and a team as code owners April 4, 2024 13:19
@tolusha tolusha requested a review from l0rd April 4, 2024 13:19
Copy link

github-actions bot commented Apr 4, 2024

Click here to review and test in web IDE: Contribute

@che-bot che-bot added this to Triage in Reviews Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

🎊 Navigate the preview: https://66158e14858a451e5fb806ae--eclipse-che-docs-pr.netlify.app 🎊

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny edits

@tolusha tolusha marked this pull request as draft April 4, 2024 14:33
@che-bot che-bot moved this from Triage to Drafts in Reviews Apr 4, 2024
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha marked this pull request as ready for review April 9, 2024 09:28
@che-bot che-bot moved this from Drafts to Triage in Reviews Apr 9, 2024
Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes the nav menu issue

otherwise, lgtm

Reviews automation moved this from Triage to Approved Apr 9, 2024
…-pre-pull-custom-images.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
@tolusha tolusha merged commit da122d5 into main Apr 9, 2024
9 of 10 checks passed
@tolusha tolusha deleted the CRW-5723 branch April 9, 2024 12:32
Reviews automation moved this from Approved to Done Apr 9, 2024
deerskindoll added a commit that referenced this pull request Apr 15, 2024
* Simplify KIP doc

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Add pages about configuring image-puller

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Fixes

Signed-off-by: Anatolii Bazko <abazko@redhat.com>

* Update modules/administration-guide/pages/configuring-image-puller-to-pre-pull-custom-images.adoc

Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>

---------

Signed-off-by: Anatolii Bazko <abazko@redhat.com>
Co-authored-by: Jana Vrbkova <jvrbkova@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Reviews
  
Done
2 participants