feat: accessing editor devfile from dashboard url #2747
Conversation
|
Click here to review and test in web IDE: |
-525C86?logo=eclipse-che&labelColor=red){kind=icon}
|
🎊 Navigate the preview: https://667b3ef88f2f1b7dd8ddcb70--eclipse-che-docs-pr.netlify.app 🎊 |
dkwon17
force-pushed
the
editor-devfile-url
branch
from
dc3a346
to
c632b49
Compare
| `pass:c,a,q[{prod-url}]/dashboard/api/editors/devfile?che-editor=publisher/editorname/version` | ||
|
|
||
| TIP: When retrieving the editor definition from within the {orch-name} cluster, the {prod-short} dashboard API can be accessed via the dashboard service: | ||
| `\http://che-dashboard.{prod-namespace}.svc.cluster.local:8080/dashboard/api/editors/devfile?che-editor=__<editor id>__` |
There was a problem hiding this comment.
I am getting this error:
Get "http://che-dashboard.eclipse-che.svc.cluster.local:8080/dashboard/api/editors/devfile": dial tcp: lookup che-dashboard.eclipse-che.svc.cluster.local: no such host --- docs/next/end-user-guide/managing-workspaces-with-apis/index.html --> http://che-dashboard.eclipse-che.svc.cluster.local:8080/dashboard/api/editors/devfile?che-editor=che-incubator/che-code/latest
Hi @deerskindoll is there a way to supress the error? This link is not supposed to be accessible unless it's accessed within a cluster
There was a problem hiding this comment.
@dkwon17 you need to add pass:c,a,q in front of the address to deactivate the link
additional thought: since the address is explicitly featuring che-dashboard, is it applicable for downstream? otherwise, you need to replace it with {prod-url}
There was a problem hiding this comment.
Updated, it is working, thank you
Good catch, it should be che upstream and devspaces downstream, so I've updated it to {prod-id-short}
For eclipse-che/che-dashboard#1134 Signed-off-by: dkwon17 <dakwon@redhat.com>
dkwon17
force-pushed
the
editor-devfile-url
branch
from
c632b49
to
2da0a46
Compare
Signed-off-by: dkwon17 <dakwon@redhat.com>
|
@deerskindoll could you clarify why the build is broken |
Build fixed. Mykhailo is looking into the general issue. |
For eclipse-che/che-dashboard#1134
What does this pull request change?
This PR documents the changes for eclipse-che/che-dashboard#1134
What issues does this pull request fix or reference?
eclipse-che/che-dashboard#1134
Specify the version of the product this pull request applies to
Che 7.88.0
Pull Request checklist
The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.
Validate language on files added or modifiedstep reports no vale warnings.