Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change che-machine-exec according to fast cloud-shell integration(server part) #63

Merged
merged 3 commits into from
Jan 8, 2020

Conversation

AndrienkoAleksandr
Copy link
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Dec 13, 2019

Referenced issue:

eclipse-che/che#15434

Proposed changes

Change che-machine-exec according to fast cloud-shell integration:

  • we get workspace ID from the env variable;
  • we have an optional flag to serve static resources. Using this flag che-machine-exec could provide some frontend part.
  • If client side doesn't set in the request machineName for exec creation - we try to create exec to the first available container in the che workspace pod.

Signed-off-by: Oleksandr Andriienko oandriie@redhat.com

@AndrienkoAleksandr AndrienkoAleksandr changed the title Change che-machine-exec according to fast cloud-shell integration Change che-machine-exec according to fast cloud-shell integration(server part) Dec 13, 2019
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@nickboldt
Copy link
Contributor

Do we need to also apply something in rhel.Dockerfile? 78d10e9#diff-3254677a7917c6c01f55212f86c57fbfR48 for example?

@AndrienkoAleksandr
Copy link
Contributor Author

Do we need to also apply something in rhel.Dockerfile?

It can be useful if we want to provide cloud shell editor for crw.

@tolusha tolusha mentioned this pull request Jan 27, 2020
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants